With --isolate-extensions, forking (via OpenURL) for extensions is not needed.

chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "base/threading/thread_restrictions.h"
 #include "build/build_config.h"
+#include "chrome/browser/download/download_shelf.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_icon_factory.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_action_runner.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/common/extensions/extension_process_policy.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
@@ skipping 809 matching lines @@
   }
 
   enum ExpectedNavigationStatus {
     EXPECTING_NAVIGATION_SUCCESS,
     EXPECTING_NAVIGATION_FAILURE,
   };
 
   void TestPopupNavigationViaGet(
       const GURL& target_url,
       ExpectedNavigationStatus expected_navigation_status) {
-    std::string navigation_starting_script =
-        "window.location = '" + target_url.spec() + "';\n";
     TestPopupNavigation(target_url, expected_navigation_status,
-                        navigation_starting_script);
+                        CreateNavigationScriptForGet(target_url));
   }
 
   void TestPopupNavigationViaPost(
       const GURL& target_url,
       ExpectedNavigationStatus expected_navigation_status) {
-    std::string navigation_starting_script =
-        "var form = document.getElementById('form');\n"
-        "form.action = '" + target_url.spec() + "';\n"
-        "form.submit();\n";
     TestPopupNavigation(target_url, expected_navigation_status,
-                        navigation_starting_script);
+                        CreateNavigationScriptForPost(target_url));
+  }
+
+  void TestPopupDownloadViaGet(const GURL& target_url) {
+    TestPopupDownload(target_url, CreateNavigationScriptForGet(target_url));
+  }
+
+  void TestPopupDownloadViaPost(const GURL& target_url) {
+    TestPopupDownload(target_url, CreateNavigationScriptForPost(target_url));
   }
 
  private:
+  std::string CreateNavigationScriptForGet(const GURL& target_url) {
+    return "window.location = '" + target_url.spec() + "';\n";
+  }
+
+  std::string CreateNavigationScriptForPost(const GURL& target_url) {
+    return "var form = document.getElementById('form');\n"
+           "form.action = '" +
+           target_url.spec() +
+           "';\n"
+           "form.submit();\n";
+  }
+
   void TestPopupNavigation(const GURL& target_url,
                            ExpectedNavigationStatus expected_navigation_status,
                            std::string navigation_starting_script) {
     // Were there any failures so far (e.g. in SetUpOnMainThread)?
     ASSERT_FALSE(HasFailure());
 
     // Simulate a click on the browser action to open the popup.
     WebContents* popup = OpenPopup(0);
     ASSERT_TRUE(popup);
     GURL popup_url = popup_extension().GetResourceURL("popup.html");
@@ skipping 51 matching lines @@
     // source WebContents]).
     TabStripModel* tabs = browser()->tab_strip_model();
     for (int i = 0; i < tabs->count(); i++) {
       WebContents* tab_contents = tabs->GetWebContentsAt(i);
       WaitForLoadStop(tab_contents);
       EXPECT_NE(target_url, tab_contents->GetLastCommittedURL())
           << "Navigating an extension pop-up should not affect tabs.";
     }
   }
 
+  void TestPopupDownload(const GURL& target_url,
+                         std::string navigation_starting_script) {
+    content::DownloadTestObserverTerminal downloads_observer(
+        content::BrowserContext::GetDownloadManager(browser()->profile()),
+        1,  // == wait_count (only waiting for a single file).
+        content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
+
+    // Override the default downloads directory, so that the test can cleanup
+    // after itself.  This section is based on CreateAndSetDownloadsDirectory
+    // method defined in a few other source files with tests.
+    std::unique_ptr<base::ScopedTempDir> downloads_directory =
+        CreateAndSetDownloadsDirectory(browser()->profile()->GetPrefs());
+    ASSERT_TRUE(downloads_directory);
+
+    // Navigate to a URL that will trigger a download (i.e. by replying with
+    // Content-Disposition: attachment; filename=...
+    // header).
+    TestPopupNavigation(target_url, EXPECTING_NAVIGATION_FAILURE,
+                        navigation_starting_script);
+
+    // Verify that a single file got downloaded.
+    downloads_observer.WaitForFinished();
+    EXPECT_EQ(0u, downloads_observer.NumDangerousDownloadsSeen());
+    EXPECT_EQ(1u, downloads_observer.NumDownloadsSeenInState(
+                      content::DownloadItem::COMPLETE));
+    EXPECT_TRUE(base::PathExists(downloads_directory->GetPath().AppendASCII(
+        "download-test3-attachment.gif")));
+
+#if !defined(OS_CHROMEOS)
+    // The test verification below is applicable only to scenarios where the
+    // download shelf is supported - on ChromeOS, instead of the download shelf,
+    // there is a download notification in the right-bottom corner of the
+    // screen.
+    EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
+    browser()->window()->GetDownloadShelf()->Hide();
+#endif
+  }
+
   const Extension* popup_extension_;
   const Extension* other_extension_;
 };
 
 // Tests that an extension pop-up cannot be navigated to a web page.
 IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, Webpage) {
   GURL web_url(embedded_test_server()->GetURL("foo.com", "/title1.html"));
 
   // The GET request will be blocked in ExtensionViewHost::OpenURLFromTab
   // (which silently drops navigations with CURRENT_TAB disposition).
@@ skipping 20 matching lines @@
 IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest,
                        PageInOtherExtension) {
   GURL other_extension_url = other_extension().GetResourceURL("other.html");
   TestPopupNavigationViaGet(other_extension_url, EXPECTING_NAVIGATION_FAILURE);
   TestPopupNavigationViaPost(other_extension_url, EXPECTING_NAVIGATION_FAILURE);
 }
 
 // Tests that navigating an extension pop-up to a http URI that returns
 // Content-Disposition: attachment; filename=...
 // works: No navigation, but download shelf visible + download goes through.
-//
-// Note - there is no "...ViaGet" flavour of this test, because we don't care
-// (yet) if GET succeeds with the download or not (it probably should succeed
-// for consistency with POST, but it always failed in M54 and before).  After
-// abandoing ShouldFork/OpenURL for all methods (not just for POST) [see comment
-// about https://crbug.com/646261 in ChromeContentRendererClient::ShouldFork]
-// GET should automagically start working for downloads.
-// TODO(lukasza): https://crbug.com/650694: Add a "Get" flavour of the test once
-// the download works both for GET and POST requests.
-IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, DownloadViaPost) {
-  // Override the default downloads directory, so that the test can cleanup
-  // after itself.  This section is based on CreateAndSetDownloadsDirectory
-  // method defined in a few other source files with tests.
-  base::ThreadRestrictions::ScopedAllowIO allow_io;
-  std::unique_ptr<base::ScopedTempDir> downloads_directory =
-      CreateAndSetDownloadsDirectory(browser()->profile()->GetPrefs());
-  ASSERT_TRUE(downloads_directory);
-
-  // Setup monitoring of the downloads.
-  content::DownloadTestObserverTerminal downloads_observer(
-      content::BrowserContext::GetDownloadManager(browser()->profile()),
-      1,  // == wait_count (only waiting for "download-test3.gif").
-      content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
-
+IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, Download) {
   // Navigate to a URL that replies with
   // Content-Disposition: attachment; filename=...
   // header.
   GURL download_url(
       embedded_test_server()->GetURL("foo.com", "/download-test3.gif"));
-  TestPopupNavigationViaPost(download_url, EXPECTING_NAVIGATION_FAILURE);
-
-  // Verify that "download-test3.gif got downloaded.
-  downloads_observer.WaitForFinished();
-  EXPECT_EQ(0u, downloads_observer.NumDangerousDownloadsSeen());
-  EXPECT_EQ(1u, downloads_observer.NumDownloadsSeenInState(
-                    content::DownloadItem::COMPLETE));
-  EXPECT_TRUE(base::PathExists(downloads_directory->GetPath().AppendASCII(
-      "download-test3-attachment.gif")));
-
-  // The test verification below is applicable only to scenarios where the
-  // download shelf is supported - on ChromeOS, instead of the download shelf,
-  // there is a download notification in the right-bottom corner of the screen.
-#if !defined(OS_CHROMEOS)
-  EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
-#endif
+  TestPopupDownloadViaGet(download_url);
+  TestPopupDownloadViaPost(download_url);
 }
 
 }  // namespace
 }  // namespace extensions