reflow comments in platform/fonts

reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true

Committed: https://crrev.com/d9dd690e6b182eb3201891b2cfe3a08a9c7945d8
Cr-Commit-Position: refs/heads/master@{#422565}

[Nico, 2016-10-03 20:26:15]

Description was changed from

==========
reflow comments in platform/fonts

BUG=563793
==========

to

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
==========

[Nico, 2016-10-03 20:26:26]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nico, 2016-10-03 20:26:30]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 20:27:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-03 20:41:18]

LGTM with nits

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/Font.cpp:303: //   rotation).
Nit: perhaps indent a bit more so it's lined up with "emit"

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/Font.cpp:553: // into it.
Nit: merge this into the previous line.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontDataCache.cpp (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontDataCache.cpp:134: // releases its
small caps FontData.
Nit: I think this would be slightly more readable on its own line, since this
isn't defining a member.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontFamily.h (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontFamily.h:81: reaper =
reaper->releaseNext();  // implicitly protects reaper->next, then
Nit: I find this more readable on its own line (also, check-webkit-style will
probably complain that this thing takes up multiple lines now but doesn't use {
}

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h:95: // glyph indices
0-255.
Nit: personal opinion strikes again: I think one line would be slightly easier
to read

[Nico, 2016-10-03 20:46:57]

Thanks!

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/Font.cpp:303: //   rotation).
On 2016/10/03 20:41:17, dcheng wrote:
> Nit: perhaps indent a bit more so it's lined up with "emit"

Done.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/Font.cpp:553: // into it.
On 2016/10/03 20:41:17, dcheng wrote:
> Nit: merge this into the previous line.

Done.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontDataCache.cpp (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontDataCache.cpp:134: // releases its
small caps FontData.
On 2016/10/03 20:41:17, dcheng wrote:
> Nit: I think this would be slightly more readable on its own line, since this
> isn't defining a member.

Done.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontFamily.h (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontFamily.h:81: reaper =
reaper->releaseNext();  // implicitly protects reaper->next, then
On 2016/10/03 20:41:17, dcheng wrote:
> Nit: I find this more readable on its own line (also, check-webkit-style will
> probably complain that this thing takes up multiple lines now but doesn't use
{
> }

Done.

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h (right):

https://codereview.chromium.org/2386333002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h:95: // glyph indices
0-255.
On 2016/10/03 20:41:17, dcheng wrote:
> Nit: personal opinion strikes again: I think one line would be slightly easier
> to read

Done.

[Nico, 2016-10-03 20:47:02]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-10-03 20:47:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2386333002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-10-03 20:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 22:14:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:14:11]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Nico, 2016-10-03 22:17:04]

Description was changed from

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
==========

to

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true
==========

[Nico, 2016-10-03 22:17:13]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:18:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 22:27:09]

Description was changed from

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true
==========

to

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true
==========

[commit-bot: I haz the power, 2016-10-03 22:27:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 22:30:35]

Description was changed from

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true
==========

to

==========
reflow comments in platform/fonts

Also disable clang-format in one test that runs into
a clang-format bug.

BUG=563793
NOTRY=true

Committed: https://crrev.com/d9dd690e6b182eb3201891b2cfe3a08a9c7945d8
Cr-Commit-Position: refs/heads/master@{#422565}
==========

[commit-bot: I haz the power, 2016-10-03 22:30:36]

Patchset 2 (id:??) landed as
https://crrev.com/d9dd690e6b182eb3201891b2cfe3a08a9c7945d8
Cr-Commit-Position: refs/heads/master@{#422565}