third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp - Issue 2386333002: reflow comments in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp

Issue 2386333002: reflow comments in platform/fonts (Closed)

Patch Set: comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp b/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp

index 62c23b20828ea52cba1e498ad0bca5b385f93f61..1f99d670705356176b455aa782c8d9de808927f7 100644

--- a/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp

+++ b/third_party/WebKit/Source/platform/fonts/skia/SkiaTextMetrics.cpp

@@ -51,7 +51,8 @@ void SkiaTextMetrics::getGlyphExtentsForHarfBuzz(hb_codepoint_t codepoint,

skBounds.set(ir);

}

- // Invert y-axis because Skia is y-grows-down but we set up HarfBuzz to be y-grows-up.

+ // Invert y-axis because Skia is y-grows-down but we set up HarfBuzz to be

+ // y-grows-up.

extents->x_bearing = SkiaScalarToHarfBuzzPosition(skBounds.fLeft);

extents->y_bearing = SkiaScalarToHarfBuzzPosition(-skBounds.fTop);

extents->width = SkiaScalarToHarfBuzzPosition(skBounds.width());