cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router()

Use EventRouter instead of ExtensionSystem::Get->event_router()

all clean-up

BUG=362672
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264765

[limasdf, 2014-04-17 15:47:46]

When you have time.
Sorry about huge & simple CL.

[not at google - send to devlin, 2014-04-17 16:09:46]

pretty much lg

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:574: ;
this semicolon looks wrong.

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
File
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
(right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:47:
if (!context)
the context can't possibly be null here, so you don't need this check.

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:359:
extensions::EventRouter* router = extensions::EventRouter::Get(profile_);
don't need extensions::

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
File
chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc
(right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries_private/media_galleries_private_event_router.cc:36:
extensions::EventRouter* router = extensions::EventRouter::Get(profile_);
don't need extensions::

[limasdf, 2014-04-17 16:22:56]

Thanks much for the reivew! PTAL.

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/event_router.cc (right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/event_router.cc:574: ;
On 2014/04/17 16:09:46, kalman wrote:
> this semicolon looks wrong.

Hm!, I had found this, but forgot to upload :/
Done.

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
File
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
(right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:47:
if (!context)
On 2014/04/17 16:09:46, kalman wrote:
> the context can't possibly be null here, so you don't need this check.

Done.

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
(right):

https://codereview.chromium.org/238633009/diff/60001/chrome/browser/extension...
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc:359:
extensions::EventRouter* router = extensions::EventRouter::Get(profile_);
On 2014/04/17 16:09:46, kalman wrote:
> don't need extensions::

Done.

[not at google - send to devlin, 2014-04-17 16:47:45]

lgtm

https://codereview.chromium.org/238633009/diff/80001/chrome/browser/extension...
File
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
(right):

https://codereview.chromium.org/238633009/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:47:
extensions::EventRouter* event_router = extensions::EventRouter::Get(context);
hm, extensions:: unnecessary here too

[limasdf, 2014-04-17 16:48:45]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-17 16:49:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/238633009/80001

[limasdf, 2014-04-17 16:49:28]

The CQ bit was unchecked by limasdf@gmail.com

[limasdf, 2014-04-17 16:54:27]

Do you have any criteria about attatching extension:: ?
Perhaps, if the code is already in extensions::, then it doesn't necessary to
attatch extensions::?

https://codereview.chromium.org/238633009/diff/80001/chrome/browser/extension...
File
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
(right):

https://codereview.chromium.org/238633009/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc:47:
extensions::EventRouter* event_router = extensions::EventRouter::Get(context);
On 2014/04/17 16:47:46, kalman wrote:
> hm, extensions:: unnecessary here too

Done.

[not at google - send to devlin, 2014-04-17 16:55:18]

Yes, if the code is already in the extensions namespace, you don't need
extensions::.

[limasdf, 2014-04-17 16:56:58]

On 2014/04/17 16:55:18, kalman wrote:
> Yes, if the code is already in the extensions namespace, you don't need
> extensions::.

I see. Thanks! :)

[limasdf, 2014-04-17 16:57:05]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-17 16:57:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/238633009/100001

[commit-bot: I haz the power, 2014-04-17 17:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-17 17:44:03]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Lei Zhang, 2014-04-17 18:47:06]

You need to fix the build, but the remaining changes that require OWNERS in
c/b/chromeos lgtm.

[limasdf, 2014-04-18 00:06:41]

On 2014/04/17 18:47:06, Lei Zhang wrote:
> You need to fix the build, but the remaining changes that require OWNERS in
> c/b/chromeos lgtm.

@thestig, Thanks and could you review c/b/chromeos?

[Lei Zhang, 2014-04-18 00:12:22]

On 2014/04/18 00:06:41, Sungguk Lim wrote:
> On 2014/04/17 18:47:06, Lei Zhang wrote:
> > You need to fix the build, but the remaining changes that require OWNERS in
> > c/b/chromeos lgtm.
> 
> @thestig, Thanks and could you review c/b/chromeos?

I already did.

[limasdf, 2014-04-18 00:18:11]

On 2014/04/18 00:12:22, Lei Zhang wrote:
> On 2014/04/18 00:06:41, Sungguk Lim wrote:
> > On 2014/04/17 18:47:06, Lei Zhang wrote:
> > > You need to fix the build, but the remaining changes that require OWNERS
in
> > > c/b/chromeos lgtm.
> > 
> > @thestig, Thanks and could you review c/b/chromeos?
> 
> I already did.

thanks much!

[limasdf, 2014-04-18 00:18:18]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-18 00:19:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/238633009/120001

[commit-bot: I haz the power, 2014-04-18 02:03:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-18 02:03:44]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_clang_dbg

[limasdf, 2014-04-18 03:12:49]

The CQ bit was checked by limasdf@gmail.com

[commit-bot: I haz the power, 2014-04-18 03:13:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/limasdf@gmail.com/238633009/140001

[commit-bot: I haz the power, 2014-04-18 10:26:46]

Change committed as 264765