Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile error for chromeos build. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h" 5 #include "chrome/browser/extensions/api/developer_private/developer_private_api. h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/app_restore_service.h" 8 #include "apps/app_restore_service.h"
9 #include "apps/app_window.h" 9 #include "apps/app_window.h"
10 #include "apps/app_window_registry.h" 10 #include "apps/app_window_registry.h"
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 } 252 }
253 253
254 if (extension) 254 if (extension)
255 event_data.item_id = extension->id(); 255 event_data.item_id = extension->id();
256 256
257 scoped_ptr<base::ListValue> args(new base::ListValue()); 257 scoped_ptr<base::ListValue> args(new base::ListValue());
258 args->Append(event_data.ToValue().release()); 258 args->Append(event_data.ToValue().release());
259 259
260 event_name = developer_private::OnItemStateChanged::kEventName; 260 event_name = developer_private::OnItemStateChanged::kEventName;
261 scoped_ptr<Event> event(new Event(event_name, args.Pass())); 261 scoped_ptr<Event> event(new Event(event_name, args.Pass()));
262 ExtensionSystem::Get(profile)->event_router()->BroadcastEvent(event.Pass()); 262 EventRouter::Get(profile)->BroadcastEvent(event.Pass());
263 } 263 }
264 264
265 void DeveloperPrivateEventRouter::OnErrorAdded(const ExtensionError* error) { 265 void DeveloperPrivateEventRouter::OnErrorAdded(const ExtensionError* error) {
266 // We don't want to handle errors thrown by extensions subscribed to these 266 // We don't want to handle errors thrown by extensions subscribed to these
267 // events (currently only the Apps Developer Tool), because doing so risks 267 // events (currently only the Apps Developer Tool), because doing so risks
268 // entering a loop. 268 // entering a loop.
269 if (extension_ids_.find(error->extension_id()) != extension_ids_.end()) 269 if (extension_ids_.find(error->extension_id()) != extension_ids_.end())
270 return; 270 return;
271 271
272 developer::EventData event_data; 272 developer::EventData event_data;
273 event_data.event_type = developer::EVENT_TYPE_ERROR_ADDED; 273 event_data.event_type = developer::EVENT_TYPE_ERROR_ADDED;
274 event_data.item_id = error->extension_id(); 274 event_data.item_id = error->extension_id();
275 275
276 scoped_ptr<base::ListValue> args(new base::ListValue); 276 scoped_ptr<base::ListValue> args(new base::ListValue);
277 args->Append(event_data.ToValue().release()); 277 args->Append(event_data.ToValue().release());
278 278
279 ExtensionSystem::Get(profile_)->event_router()->BroadcastEvent( 279 EventRouter::Get(profile_)->BroadcastEvent(scoped_ptr<Event>(new Event(
280 scoped_ptr<Event>(new Event( 280 developer_private::OnItemStateChanged::kEventName, args.Pass())));
281 developer_private::OnItemStateChanged::kEventName, args.Pass())));
282 } 281 }
283 282
284 void DeveloperPrivateAPI::SetLastUnpackedDirectory(const base::FilePath& path) { 283 void DeveloperPrivateAPI::SetLastUnpackedDirectory(const base::FilePath& path) {
285 last_unpacked_directory_ = path; 284 last_unpacked_directory_ = path;
286 } 285 }
287 286
288 void DeveloperPrivateAPI::RegisterNotifications() { 287 void DeveloperPrivateAPI::RegisterNotifications() {
289 ExtensionSystem::Get(profile_)->event_router()->RegisterObserver( 288 EventRouter::Get(profile_)->RegisterObserver(
290 this, developer_private::OnItemStateChanged::kEventName); 289 this, developer_private::OnItemStateChanged::kEventName);
291 } 290 }
292 291
293 DeveloperPrivateAPI::~DeveloperPrivateAPI() {} 292 DeveloperPrivateAPI::~DeveloperPrivateAPI() {}
294 293
295 void DeveloperPrivateAPI::Shutdown() {} 294 void DeveloperPrivateAPI::Shutdown() {}
296 295
297 void DeveloperPrivateAPI::OnListenerAdded( 296 void DeveloperPrivateAPI::OnListenerAdded(
298 const EventListenerInfo& details) { 297 const EventListenerInfo& details) {
299 if (!developer_private_event_router_) { 298 if (!developer_private_event_router_) {
300 developer_private_event_router_.reset( 299 developer_private_event_router_.reset(
301 new DeveloperPrivateEventRouter(profile_)); 300 new DeveloperPrivateEventRouter(profile_));
302 } 301 }
303 302
304 developer_private_event_router_->AddExtensionId(details.extension_id); 303 developer_private_event_router_->AddExtensionId(details.extension_id);
305 } 304 }
306 305
307 void DeveloperPrivateAPI::OnListenerRemoved( 306 void DeveloperPrivateAPI::OnListenerRemoved(
308 const EventListenerInfo& details) { 307 const EventListenerInfo& details) {
309 if (!ExtensionSystem::Get(profile_)->event_router()->HasEventListener( 308 if (!EventRouter::Get(profile_)->HasEventListener(
310 developer_private::OnItemStateChanged::kEventName)) { 309 developer_private::OnItemStateChanged::kEventName)) {
311 developer_private_event_router_.reset(NULL); 310 developer_private_event_router_.reset(NULL);
312 } else { 311 } else {
313 developer_private_event_router_->RemoveExtensionId(details.extension_id); 312 developer_private_event_router_->RemoveExtensionId(details.extension_id);
314 } 313 }
315 } 314 }
316 315
317 namespace api { 316 namespace api {
318 317
319 bool DeveloperPrivateAutoUpdateFunction::RunImpl() { 318 bool DeveloperPrivateAutoUpdateFunction::RunImpl() {
320 ExtensionUpdater* updater = GetExtensionUpdater(GetProfile()); 319 ExtensionUpdater* updater = GetExtensionUpdater(GetProfile());
(...skipping 1033 matching lines...) Expand 10 before | Expand all | Expand 10 after
1354 } 1353 }
1355 1354
1356 error_ui_util::HandleOpenDevTools(dict); 1355 error_ui_util::HandleOpenDevTools(dict);
1357 1356
1358 return true; 1357 return true;
1359 } 1358 }
1360 1359
1361 } // namespace api 1360 } // namespace api
1362 1361
1363 } // namespace extensions 1362 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/dial/dial_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698