chrome/browser/extensions/api/feedback_private/feedback_private_api.cc - Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile error for chromeos build. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/browser/extensions/api/gcm/gcm_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

index bbbb7899609a52ec3284d4e819d3f430b91ddd0a..5cbc5654c26ace67572ab2488fde37777972a194 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

@@ -14,7 +14,6 @@

#include "chrome/browser/feedback/tracing_manager.h"

#include "chrome/browser/profiles/profile.h"

#include "extensions/browser/event_router.h"

-#include "extensions/browser/extension_system.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/webui/web_ui_util.h"

@@ -69,8 +68,7 @@ void FeedbackPrivateAPI::RequestFeedback(

const GURL& page_url) {

// TODO(rkc): Remove logging once crbug.com/284662 is closed.

LOG(WARNING) << "FEEDBACK_DEBUG: Feedback requested.";

- if (browser_context_ &&

- ExtensionSystem::Get(browser_context_)->event_router()) {

+ if (browser_context_ && EventRouter::Get(browser_context_)) {

FeedbackInfo info;

info.description = description_template;

info.category_tag = make_scoped_ptr(new std::string(category_tag));

@@ -90,8 +88,7 @@ void FeedbackPrivateAPI::RequestFeedback(

// TODO(rkc): Remove logging once crbug.com/284662 is closed.

LOG(WARNING) << "FEEDBACK_DEBUG: Dispatching onFeedbackRequested event.";

- ExtensionSystem::Get(browser_context_)

- ->event_router()

+ EventRouter::Get(browser_context_)

->DispatchEventToExtension(kFeedbackExtensionId, event.Pass());

}