Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386263003: Move core/fpdfapi/fpdf_edit to core/fpdfapi/edit (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdfapi/fpdf_edit to core/fpdfapi/edit BUG=pdfium:603 Committed: https://pdfium.googlesource.com/pdfium/+/241543581696e996093bf0c2ae09ece6afe13ba2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2446 lines) Patch
M BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
A + core/fpdfapi/edit/cpdf_creator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/edit/cpdf_pagecontentgenerator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/edit/editint.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/edit/fpdf_edit_create.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D core/fpdfapi/fpdf_edit/cpdf_creator.h View 1 chunk +0 lines, -101 lines 0 comments Download
D core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.h View 1 chunk +0 lines, -43 lines 0 comments Download
D core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +0 lines, -178 lines 0 comments Download
D core/fpdfapi/fpdf_edit/editint.h View 1 chunk +0 lines, -77 lines 0 comments Download
D core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +0 lines, -2022 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 1 comment Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2391013002 Patch 1

Dependent Patchsets:

Issue 2392773003 Patch 1

Messages

Total messages: 13 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-04 15:18:51 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2386263003/diff/1/fpdfsdk/DEPS File fpdfsdk/DEPS (right): https://codereview.chromium.org/2386263003/diff/1/fpdfsdk/DEPS#newcode4 fpdfsdk/DEPS:4: '+core/fpdfapi/edit', BTW, aren't these rules redundent with line ...
4 years, 2 months ago (2016-10-04 17:58:33 UTC) #7
dsinclair
On 2016/10/04 17:58:33, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/2386263003/diff/1/fpdfsdk/DEPS > File fpdfsdk/DEPS (right): ...
4 years, 2 months ago (2016-10-04 18:01:10 UTC) #8
dsinclair
4 years, 2 months ago (2016-10-04 18:01:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386263003/1
4 years, 2 months ago (2016-10-04 18:01:32 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:01:51 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/241543581696e996093bf0c2ae09ece6afe1...

Powered by Google App Engine
This is Rietveld 408576698