Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2392773003: Move core/fpdfapi/fpdf_font to core/fpdfapi/font (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdfapi/fpdf_font to core/fpdfapi/font BUG=pdfium:603 Committed: https://pdfium.googlesource.com/pdfium/+/bc5e6d289ed40efec2b0e03427e8fc2947bf53e3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -7006 lines) Patch
M BUILD.gn View 2 chunks +23 lines, -23 lines 0 comments Download
M core/fpdfapi/cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/cmaps/GB1/cmaps_gb1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/cmaps/fpdf_cmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/font/cpdf_cidfont.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/cpdf_cidfont.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/cpdf_font.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/cpdf_font.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + core/fpdfapi/font/cpdf_fontencoding.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/cpdf_fontencoding.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/font/cpdf_simplefont.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + core/fpdfapi/font/cpdf_simplefont.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/font/cpdf_truetypefont.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/cpdf_truetypefont.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type1font.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type1font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type3char.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type3char.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type3font.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/cpdf_type3font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/font/font_int.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfapi/font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/font/fpdf_font_cid.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/fpdf_font_cid_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/font/fpdf_font_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/font/ttgsubtable.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/font/ttgsubtable.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_cidfont.h View 1 chunk +0 lines, -91 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 chunk +0 lines, -852 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_font.h View 1 chunk +0 lines, -132 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_font.cpp View 1 chunk +0 lines, -476 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_fontencoding.h View 1 chunk +0 lines, -61 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_fontencoding.cpp View 1 chunk +0 lines, -1818 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_simplefont.h View 1 chunk +0 lines, -49 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 1 chunk +0 lines, -216 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_truetypefont.h View 1 chunk +0 lines, -30 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp View 1 chunk +0 lines, -223 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type1font.h View 1 chunk +0 lines, -35 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 chunk +0 lines, -398 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type3char.h View 1 chunk +0 lines, -35 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type3char.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type3font.h View 1 chunk +0 lines, -59 lines 0 comments Download
D core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 1 chunk +0 lines, -159 lines 0 comments Download
D core/fpdfapi/fpdf_font/font_int.h View 1 chunk +0 lines, -204 lines 0 comments Download
D core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +0 lines, -307 lines 0 comments Download
D core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +0 lines, -784 lines 0 comments Download
D core/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D core/fpdfapi/fpdf_font/fpdf_font_unittest.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
D core/fpdfapi/fpdf_font/ttgsubtable.h View 1 chunk +0 lines, -301 lines 0 comments Download
D core/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +0 lines, -502 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pagemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/cpdf_type3cache.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/cpdf_type3cache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_variabletext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/cfx_unicodeencodingex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2386263003 Patch 1

Dependent Patchsets:

Issue 2386423004 Patch 1
Issue 2386423004 Patch 20001

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-04 15:31:27 UTC) #2
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-04 18:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392773003/1
4 years, 2 months ago (2016-10-04 18:08:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:08:52 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/bc5e6d289ed40efec2b0e03427e8fc2947bf...

Powered by Google App Engine
This is Rietveld 408576698