Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2391013002: Move core/fpdfapi/fpdf_cmaps to core/fpdfapi/cmaps (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdfapi/fpdf_cmaps to core/fpdfapi/cmaps BUG=pdfium:603 Committed: https://pdfium.googlesource.com/pdfium/+/a6c9215eea43b0536b228093ee7dd0e83ef62a46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -36205 lines) Patch
M BUILD.gn View 1 chunk +63 lines, -63 lines 0 comments Download
A + core/fpdfapi/cmaps/CNS1/Adobe-CNS1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/B5pc-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/B5pc-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/CNS-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/CNS-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/ETen-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/ETen-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/ETenms-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/ETenms-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/HKscs-B5-H_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/HKscs-B5-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/UniCNS-UCS2-H_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/UniCNS-UCS2-V_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/UniCNS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/CNS1/cmaps_cns1.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/cmaps/GB1/Adobe-GB1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GB-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GB-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBK-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBK-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBK2K-H_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBK2K-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBKp-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBKp-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/GBpc-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/UniGB-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/UniGB-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/GB1/cmaps_gb1.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/cmaps/GB1/cmaps_gb1.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/cmaps/Japan1/83pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/90ms-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/90ms-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/90msp-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/90msp-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/90pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/Add-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/Add-RKSJ-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/Adobe-Japan1-UCS2_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/EUC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/EUC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/Ext-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/Ext-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/UniJIS-UCS2-HW-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/UniJIS-UCS2-HW-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/UniJIS-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/UniJIS-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Japan1/cmaps_japan1.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/cmaps/Korea1/Adobe-Korea1-UCS2_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSC-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSC-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSCms-UHC-HW-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSCms-UHC-HW-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSCms-UHC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSCms-UHC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/KSCpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/UniKS-UCS2-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/UniKS-UCS2-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/UniKS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfapi/cmaps/Korea1/cmaps_korea1.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfapi/cmaps/cmap_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfapi/cmaps/fpdf_cmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/Adobe-CNS1-UCS2_5.cpp View 1 chunk +0 lines, -2131 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/B5pc-H_0.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/B5pc-V_0.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-H_0.cpp View 1 chunk +0 lines, -172 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-V_0.cpp View 1 chunk +0 lines, -189 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-H_0.cpp View 1 chunk +0 lines, -95 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-V_0.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-H_0.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-V_0.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-H_5.cpp View 1 chunk +0 lines, -414 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-V_5.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-H_3.cpp View 1 chunk +0 lines, -5483 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-V_3.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UTF16-H_0.cpp View 1 chunk +0 lines, -3245 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.h View 1 chunk +0 lines, -29 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/Adobe-GB1-UCS2_5.cpp View 1 chunk +0 lines, -3375 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GB-EUC-H_0.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GB-EUC-V_0.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-H_2.cpp View 1 chunk +0 lines, -1367 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-V_2.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBK2K-H_5.cpp View 1 chunk +0 lines, -1822 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBK2K-V_5.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-H_2.cpp View 1 chunk +0 lines, -1367 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-V_2.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-H_0.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-V_0.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-H_4.cpp View 1 chunk +0 lines, -4619 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-V_4.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.h View 1 chunk +0 lines, -27 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/83pv-RKSJ-H_1.cpp View 1 chunk +0 lines, -84 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-H_2.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-V_2.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-H_2.cpp View 1 chunk +0 lines, -67 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-V_2.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/90pv-RKSJ-H_1.cpp View 1 chunk +0 lines, -98 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-H_1.cpp View 1 chunk +0 lines, -222 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-V_1.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/Adobe-Japan1-UCS2_4.cpp View 1 chunk +0 lines, -1726 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/EUC-H_1.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/EUC-V_1.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-H_2.cpp View 1 chunk +0 lines, -232 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-V_2.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/H_1.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-H_4.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-V_4.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-H_4.cpp View 1 chunk +0 lines, -2182 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-V_4.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/V_1.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.h View 1 chunk +0 lines, -35 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/Adobe-Korea1-UCS2_2.cpp View 1 chunk +0 lines, -2050 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-H_0.cpp View 1 chunk +0 lines, -166 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-V_0.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-H_1.cpp View 1 chunk +0 lines, -235 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-V_1.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-H_1.cpp View 1 chunk +0 lines, -235 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-V_1.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/KSCpc-EUC-H_0.cpp View 1 chunk +0 lines, -180 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-H_1.cpp View 1 chunk +0 lines, -2808 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-V_1.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/UniKS-UTF16-H_0.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.h View 1 chunk +0 lines, -24 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +0 lines, -50 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/cmap_int.h View 1 chunk +0 lines, -33 lines 0 comments Download
D core/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +0 lines, -154 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 2386263003 Patch 1

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-04 15:10:46 UTC) #4
Lei Zhang
rs lgtm based on spot checking.
4 years, 2 months ago (2016-10-04 17:57:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391013002/1
4 years, 2 months ago (2016-10-04 17:58:23 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:58:59 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a6c9215eea43b0536b228093ee7dd0e83ef6...

Powered by Google App Engine
This is Rietveld 408576698