Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23857010: Revert "Revert 223907 "[password generation] Upload possible account cre..."" (Closed)

Created:
7 years, 3 months ago by Garrett Casto
Modified:
7 years, 3 months ago
Reviewers:
kkania
CC:
chromium-reviews, asvitkine+watch_chromium.org, jar (doing other things), benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Revert "Revert 223907 "[password generation] Upload possible account cre..."" Re-commit change. Update to not use <iostream> to follow. BUG=240559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -75 lines) Patch
M chrome/browser/password_manager/login_database.cc View 10 chunks +31 lines, -13 lines 0 comments Download
M chrome/browser/password_manager/login_database_unittest.cc View 2 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_form_data.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/password_manager/password_form_data.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 5 chunks +63 lines, -1 line 0 comments Download
M chrome/test/data/password/password_form.html View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/password/signup_form.html View 1 chunk +6 lines, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 4 chunks +10 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 2 chunks +13 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 3 chunks +62 lines, -10 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/core/common/autofill_messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
M components/autofill/core/common/autofill_param_traits_macros.h View 2 chunks +10 lines, -0 lines 0 comments Download
M components/autofill/core/common/form_data.h View 2 chunks +4 lines, -1 line 0 comments Download
M components/autofill/core/common/form_data.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M components/autofill/core/common/password_form.h View 3 chunks +16 lines, -0 lines 0 comments Download
M components/autofill/core/common/password_form.cc View 2 chunks +53 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Garrett Casto
7 years, 3 months ago (2013-09-18 21:54:31 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r223948.

Powered by Google App Engine
This is Rietveld 408576698