Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: components/autofill/content/renderer/password_form_conversion_utils.cc

Issue 23857010: Revert "Revert 223907 "[password generation] Upload possible account cre..."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/password_form_conversion_utils.h" 5 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
6 6
7 #include "components/autofill/content/renderer/form_autofill_util.h"
7 #include "components/autofill/core/common/password_form.h" 8 #include "components/autofill/core/common/password_form.h"
9 #include "third_party/WebKit/public/web/WebFormControlElement.h"
8 #include "third_party/WebKit/public/web/WebPasswordFormData.h" 10 #include "third_party/WebKit/public/web/WebPasswordFormData.h"
9 11
10 using WebKit::WebFormElement; 12 using WebKit::WebFormElement;
11 using WebKit::WebPasswordFormData; 13 using WebKit::WebPasswordFormData;
12 14
13 namespace autofill { 15 namespace autofill {
14 namespace { 16 namespace {
15 17
16 scoped_ptr<PasswordForm> InitPasswordFormFromWebPasswordForm( 18 scoped_ptr<PasswordForm> InitPasswordFormFromWebPasswordForm(
19 const WebFormElement& web_form,
17 const WebKit::WebPasswordFormData& web_password_form) { 20 const WebKit::WebPasswordFormData& web_password_form) {
18 PasswordForm* password_form = new PasswordForm(); 21 PasswordForm* password_form = new PasswordForm();
19 password_form->signon_realm = web_password_form.signonRealm.utf8(); 22 password_form->signon_realm = web_password_form.signonRealm.utf8();
20 password_form->origin = web_password_form.origin; 23 password_form->origin = web_password_form.origin;
21 password_form->action = web_password_form.action; 24 password_form->action = web_password_form.action;
22 password_form->submit_element = web_password_form.submitElement; 25 password_form->submit_element = web_password_form.submitElement;
23 password_form->username_element = web_password_form.userNameElement; 26 password_form->username_element = web_password_form.userNameElement;
24 password_form->username_value = web_password_form.userNameValue; 27 password_form->username_value = web_password_form.userNameValue;
25 password_form->other_possible_usernames.insert( 28 password_form->other_possible_usernames.insert(
26 password_form->other_possible_usernames.begin(), 29 password_form->other_possible_usernames.begin(),
27 web_password_form.possibleUserNames.data(), 30 web_password_form.possibleUserNames.data(),
28 web_password_form.possibleUserNames.data() + 31 web_password_form.possibleUserNames.data() +
29 web_password_form.possibleUserNames.size()); 32 web_password_form.possibleUserNames.size());
30 password_form->password_element = web_password_form.passwordElement; 33 password_form->password_element = web_password_form.passwordElement;
31 password_form->password_value = web_password_form.passwordValue; 34 password_form->password_value = web_password_form.passwordValue;
32 password_form->password_autocomplete_set = 35 password_form->password_autocomplete_set =
33 web_password_form.passwordShouldAutocomplete; 36 web_password_form.passwordShouldAutocomplete;
34 password_form->old_password_element = web_password_form.oldPasswordElement; 37 password_form->old_password_element = web_password_form.oldPasswordElement;
35 password_form->old_password_value = web_password_form.oldPasswordValue; 38 password_form->old_password_value = web_password_form.oldPasswordValue;
36 password_form->scheme = PasswordForm::SCHEME_HTML; 39 password_form->scheme = PasswordForm::SCHEME_HTML;
37 password_form->ssl_valid = false; 40 password_form->ssl_valid = false;
38 password_form->preferred = false; 41 password_form->preferred = false;
39 password_form->blacklisted_by_user = false; 42 password_form->blacklisted_by_user = false;
40 password_form->type = PasswordForm::TYPE_MANUAL; 43 password_form->type = PasswordForm::TYPE_MANUAL;
44 WebFormElementToFormData(web_form,
45 WebKit::WebFormControlElement(),
46 REQUIRE_NONE,
47 EXTRACT_NONE,
48 &password_form->form_data,
49 NULL /* FormFieldData */);
41 return scoped_ptr<PasswordForm>(password_form); 50 return scoped_ptr<PasswordForm>(password_form);
42 } 51 }
43 52
44 } // namespace 53 } // namespace
45 54
46 scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) { 55 scoped_ptr<PasswordForm> CreatePasswordForm(const WebFormElement& webform) {
47 WebPasswordFormData web_password_form(webform); 56 WebPasswordFormData web_password_form(webform);
48 if (web_password_form.isValid()) 57 if (web_password_form.isValid())
49 return InitPasswordFormFromWebPasswordForm(web_password_form); 58 return InitPasswordFormFromWebPasswordForm(webform, web_password_form);
50 return scoped_ptr<PasswordForm>(); 59 return scoped_ptr<PasswordForm>();
51 } 60 }
52 61
53 } // namespace autofill 62 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/test/data/password/signup_form.html ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698