Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2385643004: Enables GN build on windows (Closed)

Created:
4 years, 2 months ago by zra
Modified:
4 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup #

Patch Set 4 : Add .gitignore for build #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+439 lines, -335 lines) Patch
M DEPS View 1 2 chunks +7 lines, -1 line 0 comments Download
A build/.gitignore View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 8 chunks +22 lines, -174 lines 0 comments Download
M build/config/win/BUILD.gn View 1 5 chunks +5 lines, -12 lines 0 comments Download
M build/config/win/visual_studio_version.gni View 1 chunk +6 lines, -6 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 2 3 chunks +2 lines, -9 lines 0 comments Download
M build/vs_toolchain.py View 1 11 chunks +217 lines, -71 lines 0 comments Download
M runtime/BUILD.gn View 1 chunk +30 lines, -28 lines 0 comments Download
M runtime/bin/BUILD.gn View 6 chunks +67 lines, -9 lines 0 comments Download
M runtime/vm/BUILD.gn View 1 2 1 chunk +15 lines, -13 lines 0 comments Download
A tools/find_depot_tools.py View 1 chunk +44 lines, -0 lines 0 comments Download
M tools/gn.py View 1 2 3 chunks +16 lines, -5 lines 0 comments Download
M utils/invoke_dart.gni View 1 1 chunk +5 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
zra
This CL enables the GN build on Windows. It uses a VS 2015 toolchain pulled ...
4 years, 2 months ago (2016-10-03 20:18:09 UTC) #2
Cutch
LGTM with a question https://codereview.chromium.org/2385643004/diff/60001/utils/invoke_dart.gni File utils/invoke_dart.gni (right): https://codereview.chromium.org/2385643004/diff/60001/utils/invoke_dart.gni#newcode33 utils/invoke_dart.gni:33: dart = rebase_path("$dart_out_dir/dart.exe") is there ...
4 years, 2 months ago (2016-10-04 15:58:48 UTC) #3
zra
https://codereview.chromium.org/2385643004/diff/60001/utils/invoke_dart.gni File utils/invoke_dart.gni (right): https://codereview.chromium.org/2385643004/diff/60001/utils/invoke_dart.gni#newcode33 utils/invoke_dart.gni:33: dart = rebase_path("$dart_out_dir/dart.exe") On 2016/10/04 15:58:48, Cutch wrote: > ...
4 years, 2 months ago (2016-10-04 16:08:35 UTC) #4
zra
4 years, 2 months ago (2016-10-04 16:19:13 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
9a6797e6ba51846b51dce92e19658af3414db50e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698