Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5649)

Unified Diff: build/config/win/BUILD.gn

Issue 2385643004: Enables GN build on windows (Closed)
Patch Set: Add .gitignore for build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index c9391005a93688add6b97a8e220368c53427160e..ed6583ef94f116d0111b3342ee4dc0494ccea81d 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -65,6 +65,7 @@ config("common_linker_setup") {
"/FIXED:NO",
"/ignore:4199",
"/ignore:4221",
+ "/ignore:4197", # Disable multiple Dart_True export warning.
"/NXCOMPAT",
# Suggested by Microsoft Devrel to avoid
@@ -85,17 +86,9 @@ config("common_linker_setup") {
} else {
ldflags += [ "/DYNAMICBASE" ]
}
-
- # Delay loaded DLLs.
- ldflags += [
- "/DELAYLOAD:dbghelp.dll",
- "/DELAYLOAD:dwmapi.dll",
- "/DELAYLOAD:shell32.dll",
- "/DELAYLOAD:uxtheme.dll",
- ]
}
-# Subsystem --------------------------------------------------------------------
+# Subsystem -------------------------------------------------------------------
# This is appended to the subsystem to specify a minimum version.
if (current_cpu == "x64") {
@@ -114,7 +107,7 @@ config("windowed") {
ldflags = [ "/SUBSYSTEM:WINDOWS$subsystem_version_suffix" ]
}
-# Incremental linking ----------------------------------------------------------
+# Incremental linking ---------------------------------------------------------
incremental_linking_on_switch = [ "/INCREMENTAL" ]
incremental_linking_off_switch = [ "/INCREMENTAL:NO" ]
@@ -151,7 +144,7 @@ config("default_large_module_incremental_linking") {
}
}
-# Character set ----------------------------------------------------------------
+# Character set ---------------------------------------------------------------
# Not including this config means "ansi" (8-bit system codepage).
config("unicode") {
@@ -161,7 +154,7 @@ config("unicode") {
]
}
-# Lean and mean ----------------------------------------------------------------
+# Lean and mean ---------------------------------------------------------------
# Some third party code might not compile with WIN32_LEAN_AND_MEAN so we have
# to have a separate config for it. Remove this config from your target to

Powered by Google App Engine
This is Rietveld 408576698