Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: utils/invoke_dart.gni

Issue 2385643004: Enables GN build on windows (Closed)
Patch Set: Add .gitignore for build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/invoke_dart.gni
diff --git a/utils/invoke_dart.gni b/utils/invoke_dart.gni
index 287d94c633f31d1cf871aa3850cb8f520ab058eb..66705f712b2e50a6f55a8f0a435560dc8126713a 100644
--- a/utils/invoke_dart.gni
+++ b/utils/invoke_dart.gni
@@ -29,8 +29,11 @@ template("invoke_dart") {
dart_out_dir = get_label_info(
"$relative_dart_root/runtime/bin:dart($host_toolchain)", "root_out_dir")
- # TODO(zra): Add platform specific executable suffix (e.g. .exe on win)
- dart = rebase_path("$dart_out_dir/dart")
+ if (is_win) {
+ dart = rebase_path("$dart_out_dir/dart.exe")
Cutch 2016/10/04 15:58:48 is there some kind ${executable_suffix} variable t
zra 2016/10/04 16:08:35 Toolchain definitions know what the extension will
+ } else {
+ dart = rebase_path("$dart_out_dir/dart")
+ }
inputs = [
dart,
« no previous file with comments | « tools/gn.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698