content/browser/web_contents/web_contents_view_child_frame.cc - Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_view_child_frame.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)

Patch Set: Move guest ctor to private Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_view_child_frame.cc

diff --git a/content/browser/web_contents/web_contents_view_child_frame.cc b/content/browser/web_contents/web_contents_view_child_frame.cc

index bbbde021d6dcae252a1e0fbc0ce580097ddea27b..b296438b5c13fe0913b4b8dc79ee39325a17c62c 100644

--- a/content/browser/web_contents/web_contents_view_child_frame.cc

+++ b/content/browser/web_contents/web_contents_view_child_frame.cc

@@ -87,7 +87,7 @@ void WebContentsViewChildFrame::CreateView(const gfx::Size& initial_size,

RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForWidget(

RenderWidgetHost* render_widget_host,

bool is_guest_view_hack) {

- return new RenderWidgetHostViewChildFrame(render_widget_host);

+ return RenderWidgetHostViewChildFrame::Create(render_widget_host);

}

RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForPopupWidget(