content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)

Patch Set: Move guest ctor to private Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/browser/web_contents/web_contents_view_child_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index 152ecba43e069782ac0f65d69090d49814f9f22b..7fb728f2e5deead6d309d742bff24bfe39717b1e 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -1051,8 +1051,8 @@ TEST_F(RenderWidgetHostViewMacTest, GuestViewDoesNotLeak) {

view->SetDelegate(view_delegate.get());

base::WeakPtr<RenderWidgetHostViewBase> guest_rwhv_weak =

- (new RenderWidgetHostViewGuest(

- rwh, NULL, view->GetWeakPtr()))->GetWeakPtr();

+ (RenderWidgetHostViewGuest::Create(rwh, NULL, view->GetWeakPtr()))

+ ->GetWeakPtr();

// Remove the cocoa_view() so |view| also goes away before |rwh|.

{