Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: content/browser/web_contents/web_contents_view_child_frame.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)
Patch Set: Move guest ctor to private Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_view_child_frame.h" 5 #include "content/browser/web_contents/web_contents_view_child_frame.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "content/browser/frame_host/render_widget_host_view_child_frame.h" 8 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
9 #include "content/browser/web_contents/web_contents_impl.h" 9 #include "content/browser/web_contents/web_contents_impl.h"
10 #include "content/public/browser/web_contents_view_delegate.h" 10 #include "content/public/browser/web_contents_view_delegate.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 } 80 }
81 81
82 void WebContentsViewChildFrame::CreateView(const gfx::Size& initial_size, 82 void WebContentsViewChildFrame::CreateView(const gfx::Size& initial_size,
83 gfx::NativeView context) { 83 gfx::NativeView context) {
84 // The WebContentsViewChildFrame does not have a native view. 84 // The WebContentsViewChildFrame does not have a native view.
85 } 85 }
86 86
87 RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForWidget( 87 RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForWidget(
88 RenderWidgetHost* render_widget_host, 88 RenderWidgetHost* render_widget_host,
89 bool is_guest_view_hack) { 89 bool is_guest_view_hack) {
90 return new RenderWidgetHostViewChildFrame(render_widget_host); 90 return RenderWidgetHostViewChildFrame::Create(render_widget_host);
91 } 91 }
92 92
93 RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForPopupWidget( 93 RenderWidgetHostViewBase* WebContentsViewChildFrame::CreateViewForPopupWidget(
94 RenderWidgetHost* render_widget_host) { 94 RenderWidgetHost* render_widget_host) {
95 return GetOuterView()->CreateViewForPopupWidget(render_widget_host); 95 return GetOuterView()->CreateViewForPopupWidget(render_widget_host);
96 } 96 }
97 97
98 void WebContentsViewChildFrame::SetPageTitle(const base::string16& title) { 98 void WebContentsViewChildFrame::SetPageTitle(const base::string16& title) {
99 // The title is ignored for the WebContentsViewChildFrame. 99 // The title is ignored for the WebContentsViewChildFrame.
100 } 100 }
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 void WebContentsViewChildFrame::StartDragging( 165 void WebContentsViewChildFrame::StartDragging(
166 const DropData& drop_data, 166 const DropData& drop_data,
167 WebDragOperationsMask ops, 167 WebDragOperationsMask ops,
168 const gfx::ImageSkia& image, 168 const gfx::ImageSkia& image,
169 const gfx::Vector2d& image_offset, 169 const gfx::Vector2d& image_offset,
170 const DragEventSourceInfo& event_info) { 170 const DragEventSourceInfo& event_info) {
171 NOTREACHED(); 171 NOTREACHED();
172 } 172 }
173 173
174 } // namespace content 174 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698