content/browser/renderer_host/render_widget_host_view_aura_unittest.cc - Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2385333002: RenderWidgetHostViewChildFrame's called a virtual in its ctor. (Closed)

Patch Set: Move guest ctor to private Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

index 783b3d9ee446004bcb4dd80ebcbf858a73f632c1..de635b017ee6c020f3da537e92f6dc3646525ce5 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

@@ -700,8 +700,8 @@ class RenderWidgetHostViewGuestAuraTest : public RenderWidgetHostViewAuraTest {

RenderWidgetHostViewAuraTest::SetUp();

- guest_view_weak_ = (new RenderWidgetHostViewGuest(widget_host_, nullptr,

- view_->GetWeakPtr()))

+ guest_view_weak_ = (RenderWidgetHostViewGuest::Create(widget_host_, nullptr,

+ view_->GetWeakPtr()))

->GetWeakPtr();

}