Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 238513003: [Telemetry] Make Telemetry binaries platform aware. (Closed)

Created:
6 years, 8 months ago by tonyg
Modified:
6 years, 8 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Make Telemetry binaries platform aware. BUG=355646 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264100

Patch Set 1 #

Patch Set 2 : add mac binaries #

Total comments: 1

Patch Set 3 : rebase #

Patch Set 4 : move to util/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -116 lines) Patch
A tools/telemetry/bin/.gitignore View 1 1 chunk +4 lines, -0 lines 0 comments Download
D tools/telemetry/bin/IEDriverServer_32.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/IEDriverServer_64.exe.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/telemetry/bin/android/README.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/device_forwarder.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/file_poller.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/md5sum_bin.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/perf.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/perfhost.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/purge_ashmem.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/android/tcpdump.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/telemetry/bin/avconv.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/ipfw.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/ipfw_mod.ko.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/telemetry/bin/linux/avconv.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/linux/bitmaptools.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/linux/host_forwarder.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/linux/ipfw.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/linux/ipfw_mod.ko.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/linux/md5sum_bin_host.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/bin/mac/bitmaptools.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/bin/mac/clear_system_cache.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/bin/mac/md5sum_bin_host.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/telemetry/bin/mac/minidump_stackwalk.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
D tools/telemetry/bin/prebuilt/android/.gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
D tools/telemetry/bin/prebuilt/android/README.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/telemetry/bin/prebuilt/android/bitmaptools.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/device_forwarder.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/file_poller.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/host_forwarder.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/md5sum_bin.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/md5sum_bin_host.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/perf.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/perfhost.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/purge_ashmem.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/telemetry/bin/prebuilt/android/tcpdump.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
A + tools/telemetry/bin/win/IEDriverServer_32.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/bin/win/IEDriverServer_64.exe.sha1 View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/adb_commands.py View 1 2 3 2 chunks +32 lines, -25 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap.py View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/desktop_platform_backend.py View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 2 3 2 chunks +8 lines, -31 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 2 chunks +1 line, -20 lines 0 comments Download
A tools/telemetry/telemetry/util/support_binaries.py View 1 2 3 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
6 years, 8 months ago (2014-04-15 05:08:10 UTC) #1
dtu
oh jeez huge improvement lgtm https://codereview.chromium.org/238513003/diff/10001/tools/telemetry/telemetry/core/support_binaries.py File tools/telemetry/telemetry/core/support_binaries.py (right): https://codereview.chromium.org/238513003/diff/10001/tools/telemetry/telemetry/core/support_binaries.py#newcode1 tools/telemetry/telemetry/core/support_binaries.py:1: # Copyright (c) 2014 ...
6 years, 8 months ago (2014-04-15 20:26:28 UTC) #2
tonyg
On 2014/04/15 20:26:28, dtu wrote: > oh jeez huge improvement > > lgtm > > ...
6 years, 8 months ago (2014-04-15 20:41:31 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 8 months ago (2014-04-15 20:44:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/238513003/50001
6 years, 8 months ago (2014-04-15 20:45:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/238513003/50001
6 years, 8 months ago (2014-04-16 01:24:57 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 03:47:00 UTC) #7
Message was sent while issue was closed. 
Change committed as 264100

Powered by Google App Engine
This is Rietveld 408576698