Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: tools/telemetry/telemetry/core/platform/desktop_platform_backend.py

Issue 238513003: [Telemetry] Make Telemetry binaries platform aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move to util/ Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/platform/desktop_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/desktop_platform_backend.py b/tools/telemetry/telemetry/core/platform/desktop_platform_backend.py
index 10f58b9cf156fb68575b38af99a218ee51e350b7..e734049fddb14d0defb3fb1ff67296e60bcbc583 100644
--- a/tools/telemetry/telemetry/core/platform/desktop_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/desktop_platform_backend.py
@@ -5,8 +5,8 @@
import os
import subprocess
-from telemetry.core import util
from telemetry.core.platform import platform_backend
+from telemetry.util import support_binaries
class DesktopPlatformBackend(platform_backend.PlatformBackend):
@@ -14,15 +14,12 @@ class DesktopPlatformBackend(platform_backend.PlatformBackend):
# This is an abstract class. It is OK to have abstract methods.
# pylint: disable=W0223
- def GetFlushUtilityName(self):
- return NotImplementedError()
-
def FlushSystemCacheForDirectory(self, directory, ignoring=None):
assert directory and os.path.exists(directory), \
'Target directory %s must exist' % directory
- flush_command = util.FindSupportBinary(self.GetFlushUtilityName())
- assert flush_command, \
- 'You must build %s first' % self.GetFlushUtilityName()
+ flush_command = support_binaries.FindPath('clear_system_cache',
+ self.GetOSName())
+ assert flush_command, 'You must build clear_system_cache first'
args = []
directory_contents = os.listdir(directory)
« no previous file with comments | « tools/telemetry/telemetry/core/bitmap.py ('k') | tools/telemetry/telemetry/core/platform/linux_platform_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698