tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py - Issue 238513003: [Telemetry] Make Telemetry binaries platform aware.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

Issue 238513003: [Telemetry] Make Telemetry binaries platform aware. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move to util/ Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/adb_commands.py ('k') | tools/telemetry/telemetry/core/backends/webdriver/webdriver_desktop_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

index e72238a26fd098fc64ed77633cc722d9233d8e3a..3ae5b600771207983995bcfb0b4b1fed54f3ab8c 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_backend.py

@@ -16,6 +16,7 @@ from telemetry.core import exceptions

from telemetry.core import util

from telemetry.core.backends import browser_backend

from telemetry.core.backends.chrome import chrome_browser_backend

+from telemetry.util import support_binaries

class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

@@ -167,7 +168,8 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

return ''

def GetStackTrace(self):

- stackwalk = util.FindSupportBinary('minidump_stackwalk')

+ stackwalk = support_binaries.FindPath('minidump_stackwalk',

+ self._browser.platform.GetOSName())

if not stackwalk:

logging.warning('minidump_stackwalk binary not found. Must build it to '

'symbolize crash dumps. Returning browser stdout.')