Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 23851037: make gradients gm view size larger, as it is choping from the pained canvas. (Closed)

Created:
7 years, 3 months ago by edisonn
Modified:
7 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

make gradients gm view size larger, as it is choping from the pained canvas. R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=11392

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M gm/gradients.cpp View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
edisonn
7 years, 3 months ago (2013-09-17 15:10:22 UTC) #1
bsalomon
On 2013/09/17 15:10:22, edisonn wrote: lgtm, but it might be a good idea to mark ...
7 years, 3 months ago (2013-09-17 15:14:18 UTC) #2
reed1
https://codereview.chromium.org/23851037/diff/1/gm/gradients.cpp File gm/gradients.cpp (right): https://codereview.chromium.org/23851037/diff/1/gm/gradients.cpp#newcode111 gm/gradients.cpp:111: virtual SkISize onISize() { return make_isize(840, 815); } SkISize::Make(...) ...
7 years, 3 months ago (2013-09-17 15:36:47 UTC) #3
edisonn
I replaced the usage of make_isize, and I updated the size of other two gms ...
7 years, 3 months ago (2013-09-19 17:39:53 UTC) #4
edisonn
7 years, 3 months ago (2013-09-19 17:55:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r11392 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698