Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc

Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length. (Closed)
Patch Set: Address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
diff --git a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
index 8cce013524d4746bb2c7c5af59728c4c37ce1c31..0e0baf2810b887a1d1deb4e72285f7711abeb11a 100644
--- a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc
@@ -14,6 +14,12 @@
namespace metrics {
+namespace {
+
+const base::TimeDelta kZeroTime = base::TimeDelta::FromSeconds(0);
+
+} // namespace
+
ChromeVisibilityObserver::ChromeVisibilityObserver() : weak_factory_(this) {
BrowserList::AddObserver(this);
InitVisibilityGapTimeout();
@@ -23,8 +29,10 @@ ChromeVisibilityObserver::~ChromeVisibilityObserver() {
BrowserList::RemoveObserver(this);
}
-void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) {
- DesktopSessionDurationTracker::Get()->OnVisibilityChanged(active);
+void ChromeVisibilityObserver::SendVisibilityChangeEvent(
+ bool active,
+ base::TimeDelta time_ago) {
+ DesktopSessionDurationTracker::Get()->OnVisibilityChanged(active, time_ago);
}
void ChromeVisibilityObserver::CancelVisibilityChange() {
@@ -35,14 +43,14 @@ void ChromeVisibilityObserver::OnBrowserSetLastActive(Browser* browser) {
if (weak_factory_.HasWeakPtrs())
CancelVisibilityChange();
else
- SendVisibilityChangeEvent(true);
+ SendVisibilityChangeEvent(true, kZeroTime);
}
void ChromeVisibilityObserver::OnBrowserNoLongerActive(Browser* browser) {
base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
FROM_HERE,
base::Bind(&ChromeVisibilityObserver::SendVisibilityChangeEvent,
- weak_factory_.GetWeakPtr(), false),
+ weak_factory_.GetWeakPtr(), false, visibility_gap_timeout_),
visibility_gap_timeout_);
}
@@ -51,7 +59,7 @@ void ChromeVisibilityObserver::OnBrowserRemoved(Browser* browser) {
// is not visible anymore immediately without waiting.
if (BrowserList::GetInstance()->empty()) {
CancelVisibilityChange();
- SendVisibilityChangeEvent(false);
+ SendVisibilityChangeEvent(false, kZeroTime);
}
}

Powered by Google App Engine
This is Rietveld 408576698