chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc - Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length. (Closed)

Patch Set: Address nits. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc ('k') | chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

diff --git a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

index c99fdff3f418a4e86eab85be85ffc20fb8deaa01..405d6de24494cd88b429ad357e8b63254747f228 100644

--- a/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

+++ b/chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer_browsertest.cc

@@ -21,7 +21,10 @@ class MockChromeVisibilityObserver : public metrics::ChromeVisibilityObserver {

bool is_active() const { return is_active_; }

private:

- void SendVisibilityChangeEvent(bool active) override { is_active_ = active; }

+ void SendVisibilityChangeEvent(bool active,

+ base::TimeDelta time_ago) override {

+ is_active_ = active;

+ }

bool is_active_;