Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: chrome/browser/metrics/desktop_session_duration/chrome_visibility_observer.cc

Issue 2385103003: [DesktopSessionDurationTracker] Remove visibility-switch timeout from session length. (Closed)
Patch Set: Address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/desktop_session_duration/chrome_visibility_obse rver.h" 5 #include "chrome/browser/metrics/desktop_session_duration/chrome_visibility_obse rver.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "chrome/browser/metrics/desktop_session_duration/desktop_session_durati on_tracker.h" 10 #include "chrome/browser/metrics/desktop_session_duration/desktop_session_durati on_tracker.h"
11 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_list.h" 12 #include "chrome/browser/ui/browser_list.h"
13 #include "components/variations/variations_associated_data.h" 13 #include "components/variations/variations_associated_data.h"
14 14
15 namespace metrics { 15 namespace metrics {
16 16
17 namespace {
18
19 const base::TimeDelta kZeroTime = base::TimeDelta::FromSeconds(0);
20
21 } // namespace
22
17 ChromeVisibilityObserver::ChromeVisibilityObserver() : weak_factory_(this) { 23 ChromeVisibilityObserver::ChromeVisibilityObserver() : weak_factory_(this) {
18 BrowserList::AddObserver(this); 24 BrowserList::AddObserver(this);
19 InitVisibilityGapTimeout(); 25 InitVisibilityGapTimeout();
20 } 26 }
21 27
22 ChromeVisibilityObserver::~ChromeVisibilityObserver() { 28 ChromeVisibilityObserver::~ChromeVisibilityObserver() {
23 BrowserList::RemoveObserver(this); 29 BrowserList::RemoveObserver(this);
24 } 30 }
25 31
26 void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) { 32 void ChromeVisibilityObserver::SendVisibilityChangeEvent(
27 DesktopSessionDurationTracker::Get()->OnVisibilityChanged(active); 33 bool active,
34 base::TimeDelta time_ago) {
35 DesktopSessionDurationTracker::Get()->OnVisibilityChanged(active, time_ago);
28 } 36 }
29 37
30 void ChromeVisibilityObserver::CancelVisibilityChange() { 38 void ChromeVisibilityObserver::CancelVisibilityChange() {
31 weak_factory_.InvalidateWeakPtrs(); 39 weak_factory_.InvalidateWeakPtrs();
32 } 40 }
33 41
34 void ChromeVisibilityObserver::OnBrowserSetLastActive(Browser* browser) { 42 void ChromeVisibilityObserver::OnBrowserSetLastActive(Browser* browser) {
35 if (weak_factory_.HasWeakPtrs()) 43 if (weak_factory_.HasWeakPtrs())
36 CancelVisibilityChange(); 44 CancelVisibilityChange();
37 else 45 else
38 SendVisibilityChangeEvent(true); 46 SendVisibilityChangeEvent(true, kZeroTime);
39 } 47 }
40 48
41 void ChromeVisibilityObserver::OnBrowserNoLongerActive(Browser* browser) { 49 void ChromeVisibilityObserver::OnBrowserNoLongerActive(Browser* browser) {
42 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask( 50 base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
43 FROM_HERE, 51 FROM_HERE,
44 base::Bind(&ChromeVisibilityObserver::SendVisibilityChangeEvent, 52 base::Bind(&ChromeVisibilityObserver::SendVisibilityChangeEvent,
45 weak_factory_.GetWeakPtr(), false), 53 weak_factory_.GetWeakPtr(), false, visibility_gap_timeout_),
46 visibility_gap_timeout_); 54 visibility_gap_timeout_);
47 } 55 }
48 56
49 void ChromeVisibilityObserver::OnBrowserRemoved(Browser* browser) { 57 void ChromeVisibilityObserver::OnBrowserRemoved(Browser* browser) {
50 // If there are no browser instances left then we should notify that browser 58 // If there are no browser instances left then we should notify that browser
51 // is not visible anymore immediately without waiting. 59 // is not visible anymore immediately without waiting.
52 if (BrowserList::GetInstance()->empty()) { 60 if (BrowserList::GetInstance()->empty()) {
53 CancelVisibilityChange(); 61 CancelVisibilityChange();
54 SendVisibilityChangeEvent(false); 62 SendVisibilityChangeEvent(false, kZeroTime);
55 } 63 }
56 } 64 }
57 65
58 void ChromeVisibilityObserver::InitVisibilityGapTimeout() { 66 void ChromeVisibilityObserver::InitVisibilityGapTimeout() {
59 const int kDefaultVisibilityGapTimeout = 3; 67 const int kDefaultVisibilityGapTimeout = 3;
60 68
61 int timeout_seconds = kDefaultVisibilityGapTimeout; 69 int timeout_seconds = kDefaultVisibilityGapTimeout;
62 std::string param_value = variations::GetVariationParamValue( 70 std::string param_value = variations::GetVariationParamValue(
63 "DesktopSessionDuration", "visibility_gap_timeout"); 71 "DesktopSessionDuration", "visibility_gap_timeout");
64 if (!param_value.empty()) 72 if (!param_value.empty())
65 base::StringToInt(param_value, &timeout_seconds); 73 base::StringToInt(param_value, &timeout_seconds);
66 74
67 visibility_gap_timeout_ = base::TimeDelta::FromSeconds(timeout_seconds); 75 visibility_gap_timeout_ = base::TimeDelta::FromSeconds(timeout_seconds);
68 } 76 }
69 77
70 } // namespace metrics 78 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698