chrome/browser/custom_handlers/register_protocol_handler_permission_request.h - Issue 2385063005: Make PermissionRequest::GetIconId return different types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)

Patch Set: android Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/theme/theme_resources.grd ('K') | « chrome/browser/chrome_quota_permission_context.cc ('k') | chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc » ('j') | chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

index 7540d22962ca203b2581742c41ea34a3bcaf123d..2cb9d62d8cda1e566cb31b2c8c32fbeaa22f99d2 100644

--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.h

@@ -24,8 +24,7 @@ class RegisterProtocolHandlerPermissionRequest : public PermissionRequest {

private:

// PermissionRequest:

- gfx::VectorIconId GetVectorIconId() const override;

- int GetIconId() const override;

+ IconId GetIconId() const override;

base::string16 GetMessageTextFragment() const override;

GURL GetOrigin() const override;

void PermissionGranted() override;