Make PermissionRequest::GetIconId return different types

chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc

Index: chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
diff --git a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
index c3ff05e6b542f0e102b7f3054b272223baa7a576..c1b230b46d7104384b0a94b6c1b1f090a5bfc782 100644
--- a/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
+++ b/chrome/browser/custom_handlers/register_protocol_handler_permission_request.cc
@@ -12,10 +12,6 @@
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/vector_icons_public.h"
 
-#if defined(OS_MACOSX)
-#include "chrome/grit/theme_resources.h"
-#endif
-
 namespace {
 
 base::string16 GetProtocolName(
@@ -42,21 +38,9 @@ RegisterProtocolHandlerPermissionRequest
 RegisterProtocolHandlerPermissionRequest::
 ~RegisterProtocolHandlerPermissionRequest() {}
 
-gfx::VectorIconId RegisterProtocolHandlerPermissionRequest::GetVectorIconId()
+PermissionRequest::IconId RegisterProtocolHandlerPermissionRequest::GetIconId()
     const {
-#if defined(OS_MACOSX)
-  return gfx::VectorIconId::VECTOR_ICON_NONE;

[lshang, 2016/10/11 12:26:57]

Did you remove this because this file will never get compiled on MACOSX? I can
only see it's non-android from BUILD.gn file, but don't know if there's other
guarantee of it. Otherwise, it'll return  gfx::VectorIconId::PROTOCOL_HANDLER on
MACOSX, instead of gfx::VectorIconId::VECTOR_ICON_NONE after your change. Or is
this intended for some reason? 

[Evan Stade, 2016/10/12 15:12:36]

vector icons work fine on osx. At the time these ifdefs code were written, that
wasn't the case.

[lshang, 2016/10/13 05:03:10]

Are the visual representation of gfx::VectorIconId::PROTOCOL_HANDLER and
IDR_REGISTER_PROTOCOL_HANDLER the same when showing to users? I'm still a little
doubt about whether this will make a UI change, but since you are more informed
about this, I'll trust you in this. 

[Evan Stade, 2016/10/14 14:58:29]

any difference is an intentional update to better match the material design
style of iconography (I can't actually recall offhand if there is a difference
or not)

-#else
   return gfx::VectorIconId::PROTOCOL_HANDLER;
-#endif
-}
-
-int RegisterProtocolHandlerPermissionRequest::GetIconId() const {
-#if defined(OS_MACOSX)
-  return IDR_REGISTER_PROTOCOL_HANDLER;
-#else
-  return 0;
-#endif
 }
 
 base::string16