Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: chrome/browser/chrome_quota_permission_context.cc

Issue 2385063005: Make PermissionRequest::GetIconId return different types (Closed)
Patch Set: android Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_quota_permission_context.cc
diff --git a/chrome/browser/chrome_quota_permission_context.cc b/chrome/browser/chrome_quota_permission_context.cc
index 67e0be05749e2ebdf62d4bbcf5b9677b104dbda4..fdf385af33162e0a1ee215bbccdb568d870d93a6 100644
--- a/chrome/browser/chrome_quota_permission_context.cc
+++ b/chrome/browser/chrome_quota_permission_context.cc
@@ -17,16 +17,17 @@
#include "chrome/browser/tab_contents/tab_util.h"
#include "chrome/grit/generated_resources.h"
#include "chrome/grit/locale_settings.h"
-#include "chrome/grit/theme_resources.h"
#include "components/url_formatter/elide_url.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/web_contents.h"
#include "storage/common/quota/quota_types.h"
#include "ui/base/l10n/l10n_util.h"
+#include "ui/gfx/vector_icons_public.h"
#include "url/gurl.h"
#if defined(OS_ANDROID)
+#include "chrome/browser/android/android_theme_resources.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "components/infobars/core/confirm_infobar_delegate.h"
#include "components/infobars/core/infobar.h"
@@ -55,7 +56,7 @@ class QuotaPermissionRequest : public PermissionRequest {
private:
// PermissionRequest:
- int GetIconId() const override;
+ IconId GetIconId() const override;
base::string16 GetMessageTextFragment() const override;
GURL GetOrigin() const override;
void PermissionGranted() override;
@@ -81,9 +82,13 @@ QuotaPermissionRequest::QuotaPermissionRequest(
QuotaPermissionRequest::~QuotaPermissionRequest() {}
-int QuotaPermissionRequest::GetIconId() const {
+PermissionRequest::IconId QuotaPermissionRequest::GetIconId() const {
// TODO(gbillock): get the proper image here
- return IDR_INFOBAR_WARNING;
+#if defined(OS_ANDROID)
+ return IDR_ANDROID_INFOBAR_WARNING;
+#else
+ return gfx::VectorIconId::WARNING;
+#endif
}
base::string16 QuotaPermissionRequest::GetMessageTextFragment() const {

Powered by Google App Engine
This is Rietveld 408576698