"Redirecting URLs to Packaged Apps" implementation: revised

chrome/test/data/extensions/platform_apps/url_handlers/handler/test.js

Index: chrome/test/data/extensions/platform_apps/url_handlers/handler/test.js
diff --git a/chrome/test/data/extensions/platform_apps/url_handlers/handler/test.js b/chrome/test/data/extensions/platform_apps/url_handlers/handler/test.js
new file mode 100644
index 0000000000000000000000000000000000000000..fd27aa979ce08d7cfd83a9c27fccbd85fafec165
--- /dev/null
+++ b/chrome/test/data/extensions/platform_apps/url_handlers/handler/test.js
@@ -0,0 +1,36 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+chrome.app.runtime.onLaunched.addListener(function (launchData) {
+  // Test that the id and items fields in FileEntry can be read.
+  chrome.test.runTests([
+    function testUrlHandler() {
+      chrome.test.assertTrue(typeof launchData != 'undefined', "No launchData");
+      chrome.test.assertEq(launchData.id, "my_doc_url",
+          "launchData.id incorrect");
+      chrome.test.assertTrue(typeof launchData.items == 'undefined',
+          "Launched for file_handlers, not url_handlers");
+      chrome.test.assertTrue(typeof launchData.url != 'undefined',
+          "No url in launchData");
+      chrome.test.assertTrue(typeof launchData.referrerUrl != 'undefined',
+          "No referrerUrl in launchData");
+      chrome.test.assertFalse(
+          !launchData.url.match(
+               /http:\/\/.*:.*\/extensions\/platform_apps\/url_handlers\/.*/),
+          "Wrong launchData.url");

[not at google - send to devlin, 2013/09/07 00:54:56]

better would be to send a message back to the test with the launch data, like
chrome.test.sendMessage(JSON.stringify(launchData)) and assert the contents in
there. that brings the knowledge of the environment out of the app and into the
test, so it's localised.

there's not much needed here besides an app that dumbly accepts launch events
and echoes them back to the test. you can then execute code directly in the app
to do things like open links etc.

one reference is the externally connectable tests which do something similar,
and actually test with real domains (it would be good to do that rather than
testing localhost and an IP address, so that you can test things like subdomains
*not* redirecting):

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

you can then execute scripts in the background page with this:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...

for example:

std::string script =
"var a = document.createElement('a');\n"
"a.href = 'http://some-domain.com';\n"
"a.click();\n";
ExecuteScriptInBackgroundPage(profile(), id, script);

which is all you need. most of the HTML is unnecessary.

[sergeygs, 2013/09/09 09:55:36]

I'll consider this for the next round of test improvements. From what I can
tell, this is a pretty drastic departure from how things are done in the
majority of the tests within the area I've been adding my tests to.

[not at google - send to devlin, 2013/09/09 19:01:13]

Ok. See other comment I made about test improvements.

+    }
+  ]);
+
+  chrome.app.window.create(
+    "main.html",
+    { },
+    function(win) {
+      win.contentWindow.onload = function() {
+        var link = this.document.querySelector('#link');
+        link.href = launchData.url;
+        link.innerText = launchData.url;
+        chrome.test.sendMessage("Handler launched");
+      }
+    });
+});