"Redirecting URLs to Packaged Apps" implementation: revised

chrome/browser/apps/app_url_redirector.cc

Index: chrome/browser/apps/app_url_redirector.cc
diff --git a/chrome/browser/apps/app_url_redirector.cc b/chrome/browser/apps/app_url_redirector.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9d49d5b87f8e162ed6104a3282cbac9dca1069d9
--- /dev/null
+++ b/chrome/browser/apps/app_url_redirector.cc
@@ -0,0 +1,99 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/apps/app_url_redirector.h"
+
+#include "apps/launcher.h"
+#include "base/bind.h"
+#include "base/logging.h"
+#include "chrome/browser/extensions/extension_info_map.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_io_data.h"
+#include "chrome/common/extensions/api/url_handlers/url_handlers_parser.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_messages.h"
+#include "chrome/common/extensions/extension_set.h"
+#include "components/navigation_interception/intercept_navigation_resource_throttle.h"
+#include "components/navigation_interception/navigation_params.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/resource_throttle.h"
+#include "content/public/browser/web_contents.h"
+#include "net/url_request/url_request.h"
+
+
+using content::BrowserThread;
+using content::WebContents;
+using extensions::Extension;
+using extensions::UrlHandlers;
+using extensions::UrlHandlerInfo;
+
+namespace {
+
+bool LaunchAppWithUrl(
+    const scoped_refptr<const Extension> app,
+    const std::string& handler_id,
+    content::RenderViewHost* source,
+    const navigation_interception::NavigationParams& params) {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+
+  // Redirect top-level navigations only. This excludes iframes and webviews
+  // in particular.
+  if (source->IsSubframe())
+    return false;
+
+  // These are guaranteed by CreateThrottleFor below.
+  DCHECK(!params.is_post());
+  DCHECK(UrlHandlers::CanExtensionHandleUrl(app, params.url()));
+
+  WebContents* web_contents = WebContents::FromRenderViewHost(source);
+  if (!web_contents)
+    return false;
+
+  Profile* profile =
+      Profile::FromBrowserContext(web_contents->GetBrowserContext());
+
+  apps::LaunchPlatformAppWithUrl(
+      profile, app, handler_id, params.url(), params.referrer().url);
+
+  return true;
+}
+
+}  // namespace
+
+// static
+content::ResourceThrottle*
+AppUrlRedirector::MaybeCreateThrottleFor(net::URLRequest* request,
+                                         ProfileIOData* profile_io_data) {
+  // Support only GET for now.
+  if (request->method() != "GET")
+    return NULL;
+
+  if (!request->url().SchemeIsHTTPOrHTTPS())

[not at google - send to devlin, 2013/09/07 00:54:56]

ok - but make sure that you don't allow http or https in the match patterns
then. warn if they have them. otherwise it will mysteriously fail here.

[sergeygs, 2013/09/09 09:55:36]

That has been enforced in the manifest parser since the beginning, see
url_handlers_parser.cc:117.

+    return NULL;
+
+  // Never redirect URLs to apps in incognito. Technically, apps are not
+  // supported in incognito, but that may change in future.
+  // See crbug.com/240879, which tracks incognito support for v2 apps.
+  if (profile_io_data->is_incognito())
+    return NULL;
+
+  const ExtensionSet& extensions =
+      profile_io_data->GetExtensionInfoMap()->extensions();
+  for (ExtensionSet::const_iterator iter = extensions.begin();
+       iter != extensions.end();
+       ++iter) {
+    const UrlHandlerInfo* handler =
+        UrlHandlers::FindMatchingUrlHandler(*iter, request->url());
+    if (handler) {
+      return new navigation_interception::InterceptNavigationResourceThrottle(
+          request,
+          base::Bind(&LaunchAppWithUrl,
+                     scoped_refptr<const Extension>(*iter),

[not at google - send to devlin, 2013/09/07 00:54:56]

make_scoped_refptr(*iter) should do it.

[sergeygs, 2013/09/09 09:55:36]

Any real advantage?

[not at google - send to devlin, 2013/09/09 19:01:13]

In as much as it's (a) idiomatic (b) less code, so yes.

[sergeygs, 2013/09/09 20:33:03]

Actually, all of this is unnecessary. *iter already is a scoped_refptr<const
Extension>, and it's pushed on the stack by value. So I'm leaving just *iter
here.

+                     handler->id));
+    }
+  }
+
+  return NULL;
+}