"Redirecting URLs to Packaged Apps" implementation: revised

chrome/test/data/extensions/platform_apps/url_handlers/handler_with_webview/test.js

Index: chrome/test/data/extensions/platform_apps/url_handlers/handler_with_webview/test.js
diff --git a/chrome/test/data/extensions/platform_apps/url_handlers/handler_with_webview/test.js b/chrome/test/data/extensions/platform_apps/url_handlers/handler_with_webview/test.js
new file mode 100644
index 0000000000000000000000000000000000000000..cb0caf46ee5e818cfa1cce23bc710a5264ddfeb2
--- /dev/null
+++ b/chrome/test/data/extensions/platform_apps/url_handlers/handler_with_webview/test.js
@@ -0,0 +1,28 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+chrome.app.runtime.onLaunched.addListener(function (launchData) {
+  // Complete correctness of launchData is tested in another test.
+  chrome.test.assertTrue(typeof launchData !== 'undefined');
+
+  chrome.app.window.create(
+    "main.html",
+    {},
+    function(win) {
+      win.contentWindow.onload = function() {
+        // Redirect the embedded webview to the same URL we've been launched
+        // with. This should not create an endless loop of redirecting on
+        // ourselves with multiplying windows.
+        var webview = this.document.getElementById('wv');

[not at google - send to devlin, 2013/09/07 00:54:56]

no point in having |this|?

[sergeygs, 2013/09/09 09:55:36]

Done.

+        webview.src = launchData.url;
+
+        // Give webview plenty of time to navigate to make sure that doesn't
+        // relaunch the handler.
+        setTimeout(function() {
+          chrome.test.sendMessage("Handler launched");
+        }, 3000);

[not at google - send to devlin, 2013/09/07 00:54:56]

is there some kind of event you can listen to? setTimeout will either be flaky,
slow, or both.

[sergeygs, 2013/09/09 09:55:36]

Indeed, there is. Added. But I've still kept a small delay after I receive that
event, to really make sure no new delayed windows have been opened.

[not at google - send to devlin, 2013/09/09 19:01:13]

Thanks.

Except it's still going to flaky and make the test slower? If "delayed windows"
have been opened then you should be able to detect that by flushing the browser
event loop or something and asserting the correct number of windows.

[sergeygs, 2013/09/09 20:33:03]

Ok, removed the delay.

+      }
+    }.bind(this)
+  );
+});