Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2384273007: reflow comments in core/html/*.{cpp,h},core/html/imports (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, dshwang, gavinp+prerender_chromium.org, ajuma+watch-canvas_chromium.org, tfarina, blink-reviews-html_chromium.org, gasubic, fs, Justin Novosad, feature-media-reviews_chromium.org, dglazkov+blink, Rik, eric.carlson_apple.com, nessy, blink-reviews, Srirama, mlamouri+watch-blink_chromium.org, vcarbune.chromium, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in core/html/*.{cpp,h},core/html/imports BUG=563793 NOTRY=true Committed: https://crrev.com/ab33ca94648d4717acf5f2628d3e2613bc21610b Cr-Commit-Position: refs/heads/master@{#423409}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1079 lines, -720 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/CollectionIndexCache.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/CollectionType.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/FormAssociatedElement.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/FormAssociatedElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.h View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAreaElement.cpp View 1 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBRElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBaseElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLButtonElement.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 16 chunks +42 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCollection.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCollection.cpp View 2 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDialogElement.cpp View 3 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDimension.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 4 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 15 chunks +46 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.h View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.cpp View 5 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.h View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlsCollection.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormElement.cpp View 5 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp View 3 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 6 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageFallbackHelper.cpp View 5 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageLoader.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.h View 5 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 12 chunks +33 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLKeygenElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLIElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLabelElement.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 8 chunks +25 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMapElement.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 7 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 62 chunks +259 lines, -178 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaSource.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMetaElement.cpp View 6 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMeterElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLNameCollection.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.h View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 2 15 chunks +44 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptGroupElement.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionElement.cpp View 1 4 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLProgressElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLScriptElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 5 chunks +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableColElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.h View 2 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableRowElement.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableRowsCollection.cpp View 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTagCollection.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 6 chunks +13 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.h View 3 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextFormControlElement.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTrackElement.cpp View 6 chunks +48 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLViewSourceDocument.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 5 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/LinkRelAttribute.cpp View 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaDocument.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp View 7 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/PluginDocument.cpp View 1 2 4 chunks +17 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/RadioNodeList.h View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/RadioNodeList.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/TimeRanges.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImport.h View 2 chunks +23 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportLoader.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportsController.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 23 (14 generated)
Nico
4 years, 2 months ago (2016-10-05 21:12:02 UTC) #3
dcheng
LGTM, though it looks like some conflicts crept in =/ https://codereview.chromium.org/2384273007/diff/1/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp File third_party/WebKit/Source/core/html/HTMLObjectElement.cpp (right): https://codereview.chromium.org/2384273007/diff/1/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp#newcode78 ...
4 years, 2 months ago (2016-10-05 22:29:17 UTC) #7
Nico
Thanks! https://codereview.chromium.org/2384273007/diff/1/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp File third_party/WebKit/Source/core/html/HTMLObjectElement.cpp (right): https://codereview.chromium.org/2384273007/diff/1/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp#newcode78 third_party/WebKit/Source/core/html/HTMLObjectElement.cpp:78: return layoutPart(); // This will return 0 if ...
4 years, 2 months ago (2016-10-05 22:35:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273007/40001
4 years, 2 months ago (2016-10-05 22:36:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/306552)
4 years, 2 months ago (2016-10-06 02:40:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273007/40001
4 years, 2 months ago (2016-10-06 02:44:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384273007/40001
4 years, 2 months ago (2016-10-06 02:49:23 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 02:52:46 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 02:54:00 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab33ca94648d4717acf5f2628d3e2613bc21610b
Cr-Commit-Position: refs/heads/master@{#423409}

Powered by Google App Engine
This is Rietveld 408576698