Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLImageElementTest.cpp

Issue 2384273007: reflow comments in core/html/*.{cpp,h},core/html/imports (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/html/HTMLImageElement.h" 5 #include "core/html/HTMLImageElement.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/frame/FrameView.h" 8 #include "core/frame/FrameView.h"
9 #include "core/testing/DummyPageHolder.h" 9 #include "core/testing/DummyPageHolder.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 #include <memory> 11 #include <memory>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 const int viewportWidth = 500; 15 const int viewportWidth = 500;
16 const int viewportHeight = 600; 16 const int viewportHeight = 600;
17 class HTMLImageElementTest : public testing::Test { 17 class HTMLImageElementTest : public testing::Test {
18 protected: 18 protected:
19 HTMLImageElementTest() 19 HTMLImageElementTest()
20 : m_dummyPageHolder( 20 : m_dummyPageHolder(
21 DummyPageHolder::create(IntSize(viewportWidth, viewportHeight))) {} 21 DummyPageHolder::create(IntSize(viewportWidth, viewportHeight))) {}
22 22
23 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 23 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
24 }; 24 };
25 25
26 TEST_F(HTMLImageElementTest, width) { 26 TEST_F(HTMLImageElementTest, width) {
27 HTMLImageElement* image = HTMLImageElement::create( 27 HTMLImageElement* image = HTMLImageElement::create(
28 m_dummyPageHolder->document(), nullptr, /* createdByParser */ false); 28 m_dummyPageHolder->document(), nullptr, /* createdByParser */ false);
29 image->setAttribute(HTMLNames::widthAttr, "400"); 29 image->setAttribute(HTMLNames::widthAttr, "400");
30 // TODO(yoav): `width` does not impact resourceWidth until we resolve https:// github.com/ResponsiveImagesCG/picture-element/issues/268 30 // TODO(yoav): `width` does not impact resourceWidth until we resolve
31 // https://github.com/ResponsiveImagesCG/picture-element/issues/268
31 EXPECT_EQ(500, image->getResourceWidth().width); 32 EXPECT_EQ(500, image->getResourceWidth().width);
32 image->setAttribute(HTMLNames::sizesAttr, "100vw"); 33 image->setAttribute(HTMLNames::sizesAttr, "100vw");
33 EXPECT_EQ(500, image->getResourceWidth().width); 34 EXPECT_EQ(500, image->getResourceWidth().width);
34 } 35 }
35 36
36 TEST_F(HTMLImageElementTest, sourceSize) { 37 TEST_F(HTMLImageElementTest, sourceSize) {
37 HTMLImageElement* image = HTMLImageElement::create( 38 HTMLImageElement* image = HTMLImageElement::create(
38 m_dummyPageHolder->document(), nullptr, /* createdByParser */ false); 39 m_dummyPageHolder->document(), nullptr, /* createdByParser */ false);
39 image->setAttribute(HTMLNames::widthAttr, "400"); 40 image->setAttribute(HTMLNames::widthAttr, "400");
40 EXPECT_EQ(viewportWidth, image->sourceSize(*image)); 41 EXPECT_EQ(viewportWidth, image->sourceSize(*image));
41 image->setAttribute(HTMLNames::sizesAttr, "50vw"); 42 image->setAttribute(HTMLNames::sizesAttr, "50vw");
42 EXPECT_EQ(250, image->sourceSize(*image)); 43 EXPECT_EQ(250, image->sourceSize(*image));
43 } 44 }
44 45
45 } // namespace blink 46 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698