Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp

Issue 2384273007: reflow comments in core/html/*.{cpp,h},core/html/imports (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp b/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
index 320815b946723aa2f0f3cd0e1c95ae2aac19e522..6779f72da32c9a919acb37d26f0bc5ab1705ec1d 100644
--- a/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLOptionsCollection.cpp
@@ -38,10 +38,13 @@ HTMLOptionsCollection::HTMLOptionsCollection(ContainerNode& select)
}
void HTMLOptionsCollection::supportedPropertyNames(Vector<String>& names) {
- // As per http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection:
- // The supported property names consist of the non-empty values of all the id and name attributes of all the elements
- // represented by the collection, in tree order, ignoring later duplicates, with the id of an element preceding its
- // name if it contributes both, they differ from each other, and neither is the duplicate of an earlier entry.
+ // As per
+ // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmloptionscollection:
+ // The supported property names consist of the non-empty values of all the id
+ // and name attributes of all the elements represented by the collection, in
+ // tree order, ignoring later duplicates, with the id of an element preceding
+ // its name if it contributes both, they differ from each other, and neither
+ // is the duplicate of an earlier entry.
HashSet<AtomicString> existingNames;
unsigned length = this->length();
for (unsigned i = 0; i < length; ++i) {
@@ -106,7 +109,8 @@ void HTMLOptionsCollection::namedGetter(const AtomicString& name,
return;
}
- // FIXME: The spec and Firefox do not return a NodeList. They always return the first matching Element.
+ // FIXME: The spec and Firefox do not return a NodeList. They always return
+ // the first matching Element.
returnValue.setNodeList(StaticElementList::adopt(namedItems));
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLOptionElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLPlugInElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698