Move audio decoding to protocol layer

Move audio decoding to protocol layer

Previously ChromotingClient was responsible for creation of
AudioDecodeScheduler. Moved that logic to IceConnectionToHost because
WebrtcConnectionToHost will not need it. Also moved AudioDecodeScheduler
from remoting/client to remoting/protocol and simplified it.

BUG=638505
Committed: https://crrev.com/77b42df81a9c802d91dd2575b57d4780df16bf80
Cr-Commit-Position: refs/heads/master@{#422671}

[Sergey Ulanov, 2016-10-03 23:36:41]

sergeyu@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2016-10-04 00:25:38]

lgtm

https://codereview.chromium.org/2384063004/diff/1/remoting/protocol/webrtc_co...
File remoting/protocol/webrtc_connection_to_host.cc (right):

https://codereview.chromium.org/2384063004/diff/1/remoting/protocol/webrtc_co...
remoting/protocol/webrtc_connection_to_host.cc:78: NOTIMPLEMENTED();
Is NOTIMPLEMENTED appropriate here? NOTIMPLEMENTED suggests to me that it should
be implemented (and it logs a warning to remind you to do so), but based on your
CL comment, I think this is intentionally a no-op for webrtc, so an empty method
body seems more appropriate.

[Sergey Ulanov, 2016-10-04 00:42:22]

https://codereview.chromium.org/2384063004/diff/1/remoting/protocol/webrtc_co...
File remoting/protocol/webrtc_connection_to_host.cc (right):

https://codereview.chromium.org/2384063004/diff/1/remoting/protocol/webrtc_co...
remoting/protocol/webrtc_connection_to_host.cc:78: NOTIMPLEMENTED();
On 2016/10/04 00:25:38, Jamie wrote:
> Is NOTIMPLEMENTED appropriate here? NOTIMPLEMENTED suggests to me that it
should
> be implemented (and it logs a warning to remind you to do so), but based on
your
> CL comment, I think this is intentionally a no-op for webrtc, so an empty
method
> body seems more appropriate.

NOIMPLEMENTED is appropriate here. It will be implemented in a separate CL. This
class won't be using AudioDecodeScheduler because webrtc takes care of audio
decoding, but it will need to store audio_stub and audio_decode_task_runner
here.

[Sergey Ulanov, 2016-10-04 00:42:36]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2016-10-04 00:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 02:08:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 02:11:50]

Description was changed from

==========
Move audio decoding to protocol layer

Previously ChromotingClient was responsible for creation of
AudioDecodeScheduler. Moved that logic to IceConnectionToHost because
WebrtcConnectionToHost will not need it. Also moved AudioDecodeScheduler
from remoting/client to remoting/protocol and simplified it.

BUG=638505
==========

to

==========
Move audio decoding to protocol layer

Previously ChromotingClient was responsible for creation of
AudioDecodeScheduler. Moved that logic to IceConnectionToHost because
WebrtcConnectionToHost will not need it. Also moved AudioDecodeScheduler
from remoting/client to remoting/protocol and simplified it.

BUG=638505

Committed: https://crrev.com/77b42df81a9c802d91dd2575b57d4780df16bf80
Cr-Commit-Position: refs/heads/master@{#422671}
==========

[commit-bot: I haz the power, 2016-10-04 02:11:51]

Patchset 1 (id:??) landed as
https://crrev.com/77b42df81a9c802d91dd2575b57d4780df16bf80
Cr-Commit-Position: refs/heads/master@{#422671}