Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2387773003: [DevTools] Support Target.setWaitForDebuggerOnStart. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
pfeldman, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support Target.setWaitForDebuggerOnStart. Set to false while profiling. Tests are coming next. BUG=648775 Committed: https://crrev.com/5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c Cr-Commit-Position: refs/heads/master@{#422284}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M content/browser/devtools/protocol/target_handler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 7 chunks +10 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 2383743003 Patch 1
Issue 2383743003 Patch 20001

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 2 months ago (2016-09-30 20:32:00 UTC) #2
pfeldman
lgtm
4 years, 2 months ago (2016-09-30 23:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387773003/20001
4 years, 2 months ago (2016-09-30 23:59:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-01 02:12:56 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 02:16:15 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5c5ad0337ecd1504b8b3ba9abe568439e37d8b6c
Cr-Commit-Position: refs/heads/master@{#422284}

Powered by Google App Engine
This is Rietveld 408576698