Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
index f54060e8b313efc9402fdb0aab4aba48e8d1554e..f16b6391f4cb510c15015b81526d87df6604768c 100644
--- a/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
@@ -3,7 +3,7 @@
{% include 'copyright_block.txt' %}
-#include "{{v8_class}}.h"
+#include "{{cpp_class}}.h"
{% for filename in cpp_includes %}
#include "{{filename}}"
@@ -11,18 +11,18 @@
namespace blink {
-{{v8_class}}::{{v8_class}}(v8::Isolate* isolate, v8::Local<v8::Function> callback)
+{{cpp_class}}::{{cpp_class}}(v8::Isolate* isolate, v8::Local<v8::Function> callback)
: m_callback(isolate, callback)
{
DCHECK(!m_callback.isEmpty());
m_callback.setPhantom();
}
-DEFINE_TRACE({{v8_class}})
+DEFINE_TRACE({{cpp_class}})
{
}
-bool {{v8_class}}::call({{argument_declarations | join(', ')}})
+bool {{cpp_class}}::call({{argument_declarations | join(', ')}})
{
if (!scriptState->contextIsValid())
return false;

Powered by Google App Engine
This is Rietveld 408576698