Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_types.py

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_types.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_types.py b/third_party/WebKit/Source/bindings/scripts/v8_types.py
index 50eeeb16005e4f4bad6c40ff4866e37ea5a79e16..00bb5c02228e050ff2d75211a0d23b53c04e5824 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_types.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_types.py
@@ -213,7 +213,7 @@ def cpp_type(idl_type, extended_attributes=None, raw_type=False, used_as_rvalue_
for member in idl_type.member_types)
return 'const %s&' % idl_type_name if used_as_rvalue_type else idl_type_name
if idl_type.is_experimental_callback_function:
- return 'V8' + base_idl_type + '*'
+ return base_idl_type + '*'
if base_idl_type == 'void':
return base_idl_type
# Default, assume native type is a pointer with same type name as idl type
@@ -386,7 +386,7 @@ def includes_for_type(idl_type, extended_attributes=None):
base_idl_type = idl_type.constructor_type_name
if idl_type.is_experimental_callback_function:
component = IdlType.experimental_callback_functions[base_idl_type]['component_dir']
- return set(['bindings/%s/v8/V8%s.h' % (component, base_idl_type)])
+ return set(['bindings/%s/v8/%s.h' % (component, base_idl_type)])
if base_idl_type not in component_dir:
return set()
return set(['bindings/%s/v8/V8%s.h' % (component_dir[base_idl_type],
@@ -581,7 +581,7 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, variable_name
cpp_expression_format = 'V8{idl_type}::toImpl({isolate}, {v8_value}, {variable_name}, exceptionState)'
elif idl_type.is_experimental_callback_function:
cpp_expression_format = (
- 'V8{idl_type}::create({isolate}, v8::Local<v8::Function>::Cast({v8_value}))')
+ '{idl_type}::create({isolate}, v8::Local<v8::Function>::Cast({v8_value}))')
else:
cpp_expression_format = (
'V8{idl_type}::toImplWithTypeCheck({isolate}, {v8_value})')

Powered by Google App Engine
This is Rietveld 408576698