Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl

Issue 2383613003: Remove 'V8' prefix from generated callback function classes (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
index 85f0ce75b0dedbee6d3f69f0cafa97068859050b..52a6e0aa55e0bd3cc8418f1b068960df10605789 100644
--- a/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl
@@ -2,8 +2,8 @@
{% include 'copyright_block.txt' %}
-#ifndef {{v8_class}}_h
-#define {{v8_class}}_h
+#ifndef {{cpp_class}}_h
+#define {{cpp_class}}_h
{% for filename in header_includes %}
#include "{{filename}}"
@@ -16,15 +16,15 @@ class ScriptState;
class {{forward_declaration}};
{% endfor %}
-class {{exported}}{{v8_class}} final : public GarbageCollectedFinalized<{{v8_class}}> {
+class {{exported}}{{cpp_class}} final : public GarbageCollectedFinalized<{{cpp_class}}> {
public:
- static {{v8_class}}* create(v8::Isolate* isolate, v8::Local<v8::Function> callback)
+ static {{cpp_class}}* create(v8::Isolate* isolate, v8::Local<v8::Function> callback)
{
- return new {{v8_class}}(isolate, callback);
+ return new {{cpp_class}}(isolate, callback);
}
- ~{{v8_class}}() = default;
+ ~{{cpp_class}}() = default;
DECLARE_TRACE();
@@ -42,12 +42,12 @@ public:
}
private:
- {{v8_class}}(v8::Isolate* isolate, v8::Local<v8::Function>);
+ {{cpp_class}}(v8::Isolate* isolate, v8::Local<v8::Function>);
ScopedPersistent<v8::Function> m_callback;
};
} // namespace blink
-#endif // {{v8_class}}_h
+#endif // {{cpp_class}}_h
{% endfilter %}{# format_blink_cpp_source_code #}

Powered by Google App Engine
This is Rietveld 408576698