Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2383583002: Move xfa/{fwl,fxbarcode,fxgraphics}/include up to parent (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move xfa/{fwl,fxbarcode,fxgraphics}/include up to parent BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/202ad7238489934ba0c64760de5f95782b36a213

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -386 lines) Patch
M BUILD.gn View 1 6 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_util.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/cfx_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifwl_combobox.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_noteimp.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fwl/core/fwl_widgethit.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_widgetimp.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fwl/core/ifwl_adaptertimermgr.h View 2 chunks +3 lines, -3 lines 0 comments Download
D xfa/fwl/core/include/fwl_widgethit.h View 1 chunk +0 lines, -35 lines 0 comments Download
D xfa/fwl/core/include/ifwl_adaptertimermgr.h View 1 chunk +0 lines, -23 lines 0 comments Download
M xfa/fwl/theme/cfwl_widgettp.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxbarcode/BC_Library.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxbarcode/cbc_codebase.h View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxbarcode/include/BC_Library.h View 1 chunk +0 lines, -38 lines 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCodaBarWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedCode39Writer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OnedEAN8Writer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cagg_graphics.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_color.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxgraphics/cfx_graphics.h View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxgraphics/cfx_graphics.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_path.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_pattern.h View 1 chunk +1 line, -1 line 0 comments Download
D xfa/fxgraphics/include/cfx_graphics.h View 1 chunk +0 lines, -242 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 17:37:17 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:59:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383583002/40001
4 years, 2 months ago (2016-09-30 00:30:12 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:41:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/202ad7238489934ba0c64760de5f95782b36...

Powered by Google App Engine
This is Rietveld 408576698