Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2383593002: Move xfa/fxfa/include to xfa/fxfa (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Patch Set 4 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -2864 lines) Patch
M BUILD.gn View 1 3 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/xml/cfx_saxreader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/ifwl_spinbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_widgetmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/fwl_widgetimp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/cxfa_eventparam.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_checksum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffapp.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffbarcode.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffcheckbutton.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffchoicelist.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdocview.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdraw.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdraw.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffexclgroup.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_fffield.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimage.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpageview.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpath.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffpushbutton.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsignature.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsubform.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffsubform.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fftextedit.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidgethandler.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_fwladapter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_fwltheme.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/cxfa_eventparam.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/fxfa.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fxfa/fxfa_basic.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/fxfa_widget.h View 2 chunks +3 lines, -3 lines 0 comments Download
D xfa/fxfa/include/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D xfa/fxfa/include/cxfa_eventparam.h View 1 chunk +0 lines, -79 lines 0 comments Download
D xfa/fxfa/include/fxfa.h View 1 chunk +0 lines, -358 lines 0 comments Download
D xfa/fxfa/include/fxfa_basic.h View 1 chunk +0 lines, -1026 lines 0 comments Download
D xfa/fxfa/include/fxfa_widget.h View 1 chunk +0 lines, -123 lines 0 comments Download
D xfa/fxfa/include/xfa_checksum.h View 1 chunk +0 lines, -77 lines 0 comments Download
D xfa/fxfa/include/xfa_ffapp.h View 1 chunk +0 lines, -93 lines 0 comments Download
D xfa/fxfa/include/xfa_ffdoc.h View 1 chunk +0 lines, -69 lines 0 comments Download
D xfa/fxfa/include/xfa_ffdochandler.h View 1 chunk +0 lines, -31 lines 0 comments Download
D xfa/fxfa/include/xfa_ffdocview.h View 1 chunk +0 lines, -152 lines 0 comments Download
D xfa/fxfa/include/xfa_ffpageview.h View 1 chunk +0 lines, -108 lines 0 comments Download
D xfa/fxfa/include/xfa_ffwidget.h View 1 chunk +0 lines, -186 lines 0 comments Download
D xfa/fxfa/include/xfa_ffwidgethandler.h View 1 chunk +0 lines, -129 lines 0 comments Download
D xfa/fxfa/include/xfa_fontmgr.h View 1 chunk +0 lines, -100 lines 0 comments Download
D xfa/fxfa/include/xfa_rendercontext.h View 1 chunk +0 lines, -45 lines 0 comments Download
M xfa/fxfa/parser/cscript_eventpseudomodel.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_dataimporter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_document.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_document_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_measurement.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_simple_parser.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cxfa_stroke.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_valuearray.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_attributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_element_attributes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_element_properties.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_element_script.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_enum.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_basic_data_packets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_resolvenode_rs.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_utils.h View 1 chunk +1 line, -1 line 0 comments Download
A + xfa/fxfa/xfa_checksum.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_ffapp.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_ffdoc.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_ffdochandler.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_ffdocview.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fxfa/xfa_ffpageview.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + xfa/fxfa/xfa_ffwidget.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_ffwidgethandler.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + xfa/fxfa/xfa_fontmgr.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + xfa/fxfa/xfa_rendercontext.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 17:46:02 UTC) #2
Tom Sepez
RS LGTM based on spot inspection
4 years, 2 months ago (2016-09-29 19:00:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383593002/40001
4 years, 2 months ago (2016-09-30 00:42:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL) win_no_v8 on ...
4 years, 2 months ago (2016-09-30 02:42:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383593002/40001
4 years, 2 months ago (2016-09-30 02:48:33 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/2295)
4 years, 2 months ago (2016-09-30 03:01:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383593002/60001
4 years, 2 months ago (2016-09-30 03:06:15 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 03:20:27 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/5b4930967676088f2f0e5ce3b25aed77831d...

Powered by Google App Engine
This is Rietveld 408576698