Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2380713005: Move fxjs/include to fxjs (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -672 lines) Patch
M BUILD.gn View 1 2 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Object.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/JS_Value.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/cjs_runtime.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/ijs_runtime.h View 1 chunk +1 line, -1 line 0 comments Download
A + fxjs/cfxjse_arguments.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fxjs/cfxjse_arguments.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fxjs/cfxjse_class.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fxjs/cfxjse_class.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fxjs/cfxjse_context.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fxjs/cfxjse_context.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fxjs/cfxjse_runtimedata.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fxjs/cfxjse_value.h View 2 chunks +4 lines, -5 lines 0 comments Download
M fxjs/cfxjse_value.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + fxjs/fxjs_v8.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fxjs/fxjs_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fxjs/fxjse.h View 2 chunks +3 lines, -3 lines 0 comments Download
D fxjs/include/cfxjse_arguments.h View 1 chunk +0 lines, -38 lines 0 comments Download
D fxjs/include/cfxjse_class.h View 1 chunk +0 lines, -45 lines 0 comments Download
D fxjs/include/cfxjse_context.h View 1 chunk +0 lines, -65 lines 0 comments Download
D fxjs/include/cfxjse_value.h View 1 chunk +0 lines, -102 lines 0 comments Download
D fxjs/include/fxjs_v8.h View 1 chunk +0 lines, -262 lines 0 comments Download
D fxjs/include/fxjse.h View 1 chunk +0 lines, -74 lines 0 comments Download
M testing/DEPS View 1 chunk +3 lines, -3 lines 0 comments Download
M testing/js_embedder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffnotify.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidgetacc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/include/fxfa_basic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/cscript_datawindow.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_datawindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_eventpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_eventpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_hostpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_layoutpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_layoutpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_logpseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_logpseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_signaturepseudomodel.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cscript_signaturepseudomodel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_object.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/cxfa_scriptcontext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/cxfa_valuearray.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_resolvenode_rs.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2384503003 Patch 40001

Dependent Patchsets:

Issue 2383583002 Patch 40001

Messages

Total messages: 14 (10 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 17:29:40 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:53:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2380713005/30001
4 years, 2 months ago (2016-09-30 00:19:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 00:29:51 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) as
https://pdfium.googlesource.com/pdfium/+/435546810a7c48f09889c00600ad344850b7...

Powered by Google App Engine
This is Rietveld 408576698