Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2383563002: Move core/fpdftext/include to core/fpdftext (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fpdftext/include to core/fpdftext BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/e0307861b8e55c9f44e947d8bf82b9c16ec9b963

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -310 lines) Patch
M BUILD.gn View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdftext/cpdf_linkextract.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdftext/cpdf_linkextract.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdftext/cpdf_textpage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdftext/cpdf_textpagefind.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdftext/cpdf_textpagefind.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdftext/fpdf_text_int_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdftext/include/cpdf_linkextract.h View 1 chunk +0 lines, -46 lines 0 comments Download
D core/fpdftext/include/cpdf_textpage.h View 1 chunk +0 lines, -181 lines 0 comments Download
D core/fpdftext/include/cpdf_textpagefind.h View 1 chunk +0 lines, -60 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_searchex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 15:10:00 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:25:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383563002/20001
4 years, 2 months ago (2016-09-29 20:13:25 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:25:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/e0307861b8e55c9f44e947d8bf82b9c16ec9...

Powered by Google App Engine
This is Rietveld 408576698