Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2374383003: Move core/fpdfdoc/include to core/fpdfdoc (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -2202 lines) Patch
M BUILD.gn View 1 2 chunks +32 lines, -32 lines 0 comments Download
M core/fpdfapi/cpdf_pagerendercontext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cline.h View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_aaction.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_aaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_action.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_action.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/cpdf_actionfields.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_actionfields.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_annot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_annotlist.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_annotlist.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_apsettings.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_apsettings.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_bookmark.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_bookmark.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_bookmarktree.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_bookmarktree.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_defaultappearance.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_defaultappearance.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_dest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_dest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_docjsactions.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_docjsactions.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_filespec.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_filespec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_filespec_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_formcontrol.h View 2 chunks +11 lines, -11 lines 0 comments Download
M core/fpdfdoc/cpdf_formcontrol.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_formfield.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_iconfit.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_iconfit.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_interform.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/cpdf_link.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_link.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpdf_linklist.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_linklist.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_metadata.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_metadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_nametree.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_nametree.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_occontext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_occontext.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpdf_variabletext.h View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfdoc/cpdf_variabletext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + core/fpdfdoc/cpdf_viewerpreferences.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_viewerpreferences.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/cpvt_line.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfdoc/cpvt_secprops.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/cpvt_section.h View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfdoc/cpvt_sectioninfo.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fpdfdoc/cpvt_word.h View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpvt_wordinfo.h View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/cpvt_wordplace.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/cpvt_wordprops.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + core/fpdfdoc/cpvt_wordrange.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/doc_tagged.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fpdfdoc/fpdf_tagged.h View 2 chunks +3 lines, -3 lines 0 comments Download
D core/fpdfdoc/include/cpdf_aaction.h View 1 chunk +0 lines, -51 lines 0 comments Download
D core/fpdfdoc/include/cpdf_action.h View 1 chunk +0 lines, -59 lines 0 comments Download
D core/fpdfdoc/include/cpdf_actionfields.h View 1 chunk +0 lines, -29 lines 0 comments Download
D core/fpdfdoc/include/cpdf_annot.h View 1 chunk +0 lines, -131 lines 0 comments Download
D core/fpdfdoc/include/cpdf_annotlist.h View 1 chunk +0 lines, -64 lines 0 comments Download
D core/fpdfdoc/include/cpdf_bookmark.h View 1 chunk +0 lines, -33 lines 0 comments Download
D core/fpdfdoc/include/cpdf_bookmarktree.h View 1 chunk +0 lines, -26 lines 0 comments Download
D core/fpdfdoc/include/cpdf_defaultappearance.h View 1 chunk +0 lines, -52 lines 0 comments Download
D core/fpdfdoc/include/cpdf_dest.h View 1 chunk +0 lines, -32 lines 0 comments Download
D core/fpdfdoc/include/cpdf_docjsactions.h View 1 chunk +0 lines, -29 lines 0 comments Download
D core/fpdfdoc/include/cpdf_filespec.h View 1 chunk +0 lines, -37 lines 0 comments Download
D core/fpdfdoc/include/cpdf_formcontrol.h View 1 chunk +0 lines, -134 lines 0 comments Download
D core/fpdfdoc/include/cpdf_formfield.h View 1 chunk +0 lines, -168 lines 0 comments Download
D core/fpdfdoc/include/cpdf_iconfit.h View 1 chunk +0 lines, -30 lines 0 comments Download
D core/fpdfdoc/include/cpdf_interform.h View 1 chunk +0 lines, -119 lines 0 comments Download
D core/fpdfdoc/include/cpdf_link.h View 1 chunk +0 lines, -31 lines 0 comments Download
D core/fpdfdoc/include/cpdf_linklist.h View 1 chunk +0 lines, -36 lines 0 comments Download
D core/fpdfdoc/include/cpdf_metadata.h View 1 chunk +0 lines, -26 lines 0 comments Download
D core/fpdfdoc/include/cpdf_nametree.h View 1 chunk +0 lines, -34 lines 0 comments Download
D core/fpdfdoc/include/cpdf_occontext.h View 1 chunk +0 lines, -42 lines 0 comments Download
D core/fpdfdoc/include/cpdf_variabletext.h View 1 chunk +0 lines, -245 lines 0 comments Download
D core/fpdfdoc/include/cpdf_viewerpreferences.h View 1 chunk +0 lines, -34 lines 0 comments Download
D core/fpdfdoc/include/cpvt_line.h View 1 chunk +0 lines, -25 lines 0 comments Download
D core/fpdfdoc/include/cpvt_secprops.h View 1 chunk +0 lines, -30 lines 0 comments Download
D core/fpdfdoc/include/cpvt_section.h View 1 chunk +0 lines, -22 lines 0 comments Download
D core/fpdfdoc/include/cpvt_word.h View 1 chunk +0 lines, -38 lines 0 comments Download
D core/fpdfdoc/include/cpvt_wordplace.h View 1 chunk +0 lines, -73 lines 0 comments Download
D core/fpdfdoc/include/cpvt_wordprops.h View 1 chunk +0 lines, -58 lines 0 comments Download
D core/fpdfdoc/include/cpvt_wordrange.h View 1 chunk +0 lines, -59 lines 0 comments Download
D core/fpdfdoc/include/fpdf_tagged.h View 1 chunk +0 lines, -93 lines 0 comments Download
D core/fpdfdoc/include/ipdf_formnotify.h View 1 chunk +0 lines, -32 lines 0 comments Download
D core/fpdfdoc/include/ipvt_fontmap.h View 1 chunk +0 lines, -29 lines 0 comments Download
A + core/fpdfdoc/ipdf_formnotify.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fpdfdoc/ipvt_fontmap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/tagged_int.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/fsdk_actionhandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_ap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/fxedit/fxet_list.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/include/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/include/fxet_edit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/cba_annotiterator.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_annot.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_annothandlermgr.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_baannot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_environment.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/cpdfsdk_interform.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/cpdfsdk_widget.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/PublicMethods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2376153004 Patch 20001

Dependent Patchsets:

Issue 2383563002 Patch 20001

Messages

Total messages: 8 (4 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 15:05:46 UTC) #2
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-29 18:23:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374383003/20001
4 years, 2 months ago (2016-09-29 19:49:48 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:13:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/1727aee85f22d9403e6cd8a0f786b9b7c0a2...

Powered by Google App Engine
This is Rietveld 408576698