Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 2381063002: Move core/fxcodec/codec/include and core/fxcodec/include files up (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/fxcodec/codec/include and core/fxcodec/include files up BUG=pdfium:611 Committed: https://pdfium.googlesource.com/pdfium/+/8a4e286e686c3027f382afb07d3ddcec4610fdd9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -561 lines) Patch
M BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/cpdf_modulemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + core/fxcodec/JBig2_DocumentContext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxcodec/codec/ccodec_iccmodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/ccodec_jbig2module.h View 1 chunk +1 line, -1 line 0 comments Download
A + core/fxcodec/codec/ccodec_progressivedecoder.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fxcodec/codec/codec_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_bmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_fax.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_icc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jbig.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_png.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcodec/codec/fx_codec_tiff.cpp View 1 chunk +1 line, -1 line 0 comments Download
D core/fxcodec/codec/include/ccodec_progressivedecoder.h View 1 chunk +0 lines, -238 lines 0 comments Download
A + core/fxcodec/fx_codec.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + core/fxcodec/fx_codec_def.h View 2 chunks +3 lines, -3 lines 0 comments Download
D core/fxcodec/include/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D core/fxcodec/include/JBig2_DocumentContext.h View 1 chunk +0 lines, -34 lines 0 comments Download
D core/fxcodec/include/fx_codec.h View 1 chunk +0 lines, -129 lines 0 comments Download
D core/fxcodec/include/fx_codec_def.h View 1 chunk +0 lines, -92 lines 0 comments Download
M core/fxcodec/jbig2/JBig2_Context.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_composite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_convert.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/include/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/include/xfa_ffwidget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-09-29 15:19:32 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2381063002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2381063002/diff/1/BUILD.gn#newcode572 BUILD.gn:572: "core/fxcodec/JBig2_DocumentContext.h", Do we need to have the case-sensitivity ...
4 years, 2 months ago (2016-09-29 18:32:37 UTC) #3
dsinclair
https://codereview.chromium.org/2381063002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2381063002/diff/1/BUILD.gn#newcode572 BUILD.gn:572: "core/fxcodec/JBig2_DocumentContext.h", On 2016/09/29 18:32:37, Tom Sepez wrote: > Do ...
4 years, 2 months ago (2016-09-29 19:03:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2381063002/20001
4 years, 2 months ago (2016-09-29 20:26:06 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 20:43:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8a4e286e686c3027f382afb07d3ddcec4610...

Powered by Google App Engine
This is Rietveld 408576698