Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: public/platform/WebLayer.h

Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change GraphicsLayer and LinkHighlight to clarify ownership transfer Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/web/LinkHighlight.cpp ('K') | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebLayer.h
diff --git a/public/platform/WebLayer.h b/public/platform/WebLayer.h
index dd84083d215b141f253b11a6c574622eb7ab8437..e467c14f304d485f985fde99e323c0be40c3aee5 100644
--- a/public/platform/WebLayer.h
+++ b/public/platform/WebLayer.h
@@ -143,6 +143,8 @@ public:
virtual void setAnimationDelegate(WebAnimationDelegate*) = 0;
// Returns false if the animation cannot be added.
+ // After it, the given WebAnimation object is invalid because it passes
+ // the ownership of internal structure of WebAnimation to Chromium.
jamesr 2013/09/20 18:52:14 I would simplify this to "The WebLayer takes owner
dshwang 2013/09/20 19:03:58 It is because now we does pass ownership of the We
virtual bool addAnimation(WebAnimation*) = 0;
// Removes all animations with the given id.
« Source/web/LinkHighlight.cpp ('K') | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698