Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: public/platform/WebLayer.h

Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change GraphicsLayer and LinkHighlight to clarify ownership transfer Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« Source/web/LinkHighlight.cpp ('K') | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 // Provides a bitfield that describe why this composited layer was created. 136 // Provides a bitfield that describe why this composited layer was created.
137 virtual void setCompositingReasons(WebCompositingReasons) = 0; 137 virtual void setCompositingReasons(WebCompositingReasons) = 0;
138 138
139 // An animation delegate is notified when animations are started and 139 // An animation delegate is notified when animations are started and
140 // stopped. The WebLayer does not take ownership of the delegate, and it is 140 // stopped. The WebLayer does not take ownership of the delegate, and it is
141 // the responsibility of the client to reset the layer's delegate before 141 // the responsibility of the client to reset the layer's delegate before
142 // deleting the delegate. 142 // deleting the delegate.
143 virtual void setAnimationDelegate(WebAnimationDelegate*) = 0; 143 virtual void setAnimationDelegate(WebAnimationDelegate*) = 0;
144 144
145 // Returns false if the animation cannot be added. 145 // Returns false if the animation cannot be added.
146 // After it, the given WebAnimation object is invalid because it passes
147 // the ownership of internal structure of WebAnimation to Chromium.
jamesr 2013/09/20 18:52:14 I would simplify this to "The WebLayer takes owner
dshwang 2013/09/20 19:03:58 It is because now we does pass ownership of the We
146 virtual bool addAnimation(WebAnimation*) = 0; 148 virtual bool addAnimation(WebAnimation*) = 0;
147 149
148 // Removes all animations with the given id. 150 // Removes all animations with the given id.
149 virtual void removeAnimation(int animationId) = 0; 151 virtual void removeAnimation(int animationId) = 0;
150 152
151 // Removes all animations with the given id targeting the given property. 153 // Removes all animations with the given id targeting the given property.
152 virtual void removeAnimation(int animationId, WebAnimation::TargetProperty) = 0; 154 virtual void removeAnimation(int animationId, WebAnimation::TargetProperty) = 0;
153 155
154 // Pauses all animations with the given id. 156 // Pauses all animations with the given id.
155 virtual void pauseAnimation(int animationId, double timeOffset) = 0; 157 virtual void pauseAnimation(int animationId, double timeOffset) = 0;
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 217
216 // True if the layer is not part of a tree attached to a WebLayerTreeView. 218 // True if the layer is not part of a tree attached to a WebLayerTreeView.
217 virtual bool isOrphan() const = 0; 219 virtual bool isOrphan() const = 0;
218 220
219 virtual void setWebLayerClient(WebLayerClient*) = 0; 221 virtual void setWebLayerClient(WebLayerClient*) = 0;
220 }; 222 };
221 223
222 } // namespace WebKit 224 } // namespace WebKit
223 225
224 #endif // WebLayer_h 226 #endif // WebLayer_h
OLDNEW
« Source/web/LinkHighlight.cpp ('K') | « Source/web/LinkHighlight.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698