Source/web/LinkHighlight.cpp - Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/LinkHighlight.cpp

Issue 23834010: Change WebLayer::addAnimation to transfer ownership of WebAnimation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change GraphicsLayer and LinkHighlight to clarify ownership transfer Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/LinkHighlight.cpp

diff --git a/Source/web/LinkHighlight.cpp b/Source/web/LinkHighlight.cpp

index fbfb13f39aac3adf9474534c654bf27ddb54be68..06abda5e5f666982e17bf52d42a4614441ce9453 100644

--- a/Source/web/LinkHighlight.cpp

+++ b/Source/web/LinkHighlight.cpp

@@ -271,10 +271,11 @@ void LinkHighlight::startHighlightAnimationIfNeeded()

// For layout tests we don't fade out.

curve->add(WebFloatKeyframe(fadeDuration + extraDurationRequired, WebKit::layoutTestMode() ? startOpacity : 0));

- m_animation = adoptPtr(compositorSupport->createAnimation(*curve, WebAnimation::TargetPropertyOpacity));

+ OwnPtr<WebAnimation> animation = adoptPtr(compositorSupport->createAnimation(*curve, WebAnimation::TargetPropertyOpacity));

m_contentLayer->layer()->setDrawsContent(true);

- m_contentLayer->layer()->addAnimation(m_animation.get());

+ m_contentLayer->layer()->addAnimation(animation.get());

jamesr 2013/09/20 18:52:14 this would be clearer if you wrote this line "anim

dshwang 2013/09/20 19:03:58 Ditto.

+ animation.clear();

invalidate();

m_owningWebViewImpl->scheduleAnimation();

« Source/core/rendering/RenderLayerBacking.cpp ('K') | « Source/web/LinkHighlight.h ('k') | public/platform/WebLayer.h » ('j') | public/platform/WebLayer.h » ('J')