Remove stl_util's deletion functions from net/cookies/ and net/extras/.

Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
Committed: https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77
Cr-Commit-Position: refs/heads/master@{#424338}

[Avi (use Gerrit), 2016-10-02 05:00:25]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 05:00:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 05:06:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 05:06:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Avi (use Gerrit), 2016-10-02 05:16:41]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-02 05:16:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-02 05:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-02 05:23:01]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2016-10-05 15:41:51]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:42:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 15:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:56:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Avi (use Gerrit), 2016-10-05 18:38:09]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 18:52:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 18:52:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Avi (use Gerrit), 2016-10-05 19:08:06]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:08:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-05 19:39:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-05 21:09:42]

avi@chromium.org changed reviewers:
+ davidben@chromium.org, ellyjones@google.com

[Avi (use Gerrit), 2016-10-05 21:09:43]

davidben: net/ and content/browser/net
ellyjones: ios/

[Avi (use Gerrit), 2016-10-05 21:10:12]

Description was changed from

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
==========

to

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
==========

[Avi (use Gerrit), 2016-10-05 21:10:12]

avi@chromium.org changed reviewers:
+ ellyjones@chromium.org
- ellyjones@google.com

[commit-bot: I haz the power, 2016-10-05 21:41:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 21:41:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elly Fong-Jones, 2016-10-06 14:05:05]

/ios lgtm

[Avi (use Gerrit), 2016-10-06 21:31:16]

davidben?

[davidben, 2016-10-10 23:05:00]

Wow, the ownership here was truly horrific. Thanks a bunch for cleaning this up.
lgtm.

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
File net/cookies/cookie_monster.h (left):

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
net/cookies/cookie_monster.h:454: const std::vector<CanonicalCookie*>& cookies);
Wow. Okay, passing a const-ref to an array of T*s which you are expected to take
ownership of is seriously nuts. :-(

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_store_test.h (right):

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
net/cookies/cookie_monster_store_test.h:35: // instead we post a
LoadedCallbackTask.
Existing problem, but this comment seems a little dubious. Took me forever to
figure out what it was trying to do, but it seems LoadedCallbbackTask can be
taken out completely and the call sites replaced with:

base::ThreadedTaskRunnerHandle::Get()->PostTask(
    FROM_HERE,
    base::Bind(loaded_callback, base::Passed(&out_cookies)));

(No need to do this in this CL, unless you feel like it. Especially if it's not
quite as trivial as it seems. I can see about doing that as a follow-up.)

[Avi (use Gerrit), 2016-10-11 00:57:49]

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
File net/cookies/cookie_monster_store_test.h (right):

https://codereview.chromium.org/2383393002/diff/100001/net/cookies/cookie_mon...
net/cookies/cookie_monster_store_test.h:35: // instead we post a
LoadedCallbackTask.
On 2016/10/10 23:05:00, davidben wrote:
> Existing problem, but this comment seems a little dubious. Took me forever to
> figure out what it was trying to do, but it seems LoadedCallbbackTask can be
> taken out completely and the call sites replaced with:
> 
> base::ThreadedTaskRunnerHandle::Get()->PostTask(
>     FROM_HERE,
>     base::Bind(loaded_callback, base::Passed(&out_cookies)));
> 
> (No need to do this in this CL, unless you feel like it. Especially if it's
not
> quite as trivial as it seems. I can see about doing that as a follow-up.)

Let's give that a try.

[Avi (use Gerrit), 2016-10-11 01:10:10]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-10-11 01:10:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2383393002/#ps120001
(title: "removing")

[commit-bot: I haz the power, 2016-10-11 01:10:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 02:01:00]

Description was changed from

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
==========

to

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
==========

[commit-bot: I haz the power, 2016-10-11 02:01:01]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-11 02:05:39]

Description was changed from

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939
==========

to

==========
Remove stl_util's deletion functions from net/cookies/ and net/extras/.

BUG=555865, 556939

Committed: https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77
Cr-Commit-Position: refs/heads/master@{#424338}
==========

[commit-bot: I haz the power, 2016-10-11 02:05:41]

Patchset 7 (id:??) landed as
https://crrev.com/e7cd11a992b871c29e005a67697dc6f3fbb6db77
Cr-Commit-Position: refs/heads/master@{#424338}