| Index: net/cookies/cookie_monster_store_test.cc
|
| diff --git a/net/cookies/cookie_monster_store_test.cc b/net/cookies/cookie_monster_store_test.cc
|
| index 7a8af87c47e136d047500b633893d2b26afe7b97..27e6dd6232df37f6854f5d44006258ffdfed7b93 100644
|
| --- a/net/cookies/cookie_monster_store_test.cc
|
| +++ b/net/cookies/cookie_monster_store_test.cc
|
| @@ -19,14 +19,6 @@
|
|
|
| namespace net {
|
|
|
| -LoadedCallbackTask::LoadedCallbackTask(LoadedCallback loaded_callback,
|
| - std::vector<CanonicalCookie*> cookies)
|
| - : loaded_callback_(loaded_callback), cookies_(cookies) {
|
| -}
|
| -
|
| -LoadedCallbackTask::~LoadedCallbackTask() {
|
| -}
|
| -
|
| CookieStoreCommand::CookieStoreCommand(
|
| Type type,
|
| const CookieMonster::PersistentCookieStore::LoadedCallback& loaded_callback,
|
| @@ -46,9 +38,9 @@ MockPersistentCookieStore::MockPersistentCookieStore()
|
|
|
| void MockPersistentCookieStore::SetLoadExpectation(
|
| bool return_value,
|
| - const std::vector<CanonicalCookie*>& result) {
|
| + std::vector<std::unique_ptr<CanonicalCookie>> result) {
|
| load_return_value_ = return_value;
|
| - load_result_ = result;
|
| + load_result_.swap(result);
|
| }
|
|
|
| void MockPersistentCookieStore::Load(const LoadedCallback& loaded_callback) {
|
| @@ -57,15 +49,13 @@ void MockPersistentCookieStore::Load(const LoadedCallback& loaded_callback) {
|
| CookieStoreCommand(CookieStoreCommand::LOAD, loaded_callback, ""));
|
| return;
|
| }
|
| - std::vector<CanonicalCookie*> out_cookies;
|
| + std::vector<std::unique_ptr<CanonicalCookie>> out_cookies;
|
| if (load_return_value_) {
|
| - out_cookies = load_result_;
|
| + out_cookies.swap(load_result_);
|
| loaded_ = true;
|
| }
|
| base::ThreadTaskRunnerHandle::Get()->PostTask(
|
| - FROM_HERE,
|
| - base::Bind(&LoadedCallbackTask::Run,
|
| - new LoadedCallbackTask(loaded_callback, out_cookies)));
|
| + FROM_HERE, base::Bind(loaded_callback, base::Passed(&out_cookies)));
|
| }
|
|
|
| void MockPersistentCookieStore::LoadCookiesForKey(
|
| @@ -79,11 +69,9 @@ void MockPersistentCookieStore::LoadCookiesForKey(
|
| if (!loaded_) {
|
| Load(loaded_callback);
|
| } else {
|
| + std::vector<std::unique_ptr<CanonicalCookie>> empty_cookies;
|
| base::ThreadTaskRunnerHandle::Get()->PostTask(
|
| - FROM_HERE,
|
| - base::Bind(&LoadedCallbackTask::Run,
|
| - new LoadedCallbackTask(loaded_callback,
|
| - std::vector<CanonicalCookie*>())));
|
| + FROM_HERE, base::Bind(loaded_callback, base::Passed(&empty_cookies)));
|
| }
|
| }
|
|
|
| @@ -151,11 +139,11 @@ std::unique_ptr<CanonicalCookie> BuildCanonicalCookie(
|
| void AddCookieToList(const GURL& url,
|
| const std::string& cookie_line,
|
| const base::Time& creation_time,
|
| - std::vector<CanonicalCookie*>* out_list) {
|
| + std::vector<std::unique_ptr<CanonicalCookie>>* out_list) {
|
| std::unique_ptr<CanonicalCookie> cookie(
|
| BuildCanonicalCookie(url, cookie_line, creation_time));
|
|
|
| - out_list->push_back(cookie.release());
|
| + out_list->push_back(std::move(cookie));
|
| }
|
|
|
| MockSimplePersistentCookieStore::MockSimplePersistentCookieStore()
|
| @@ -164,16 +152,13 @@ MockSimplePersistentCookieStore::MockSimplePersistentCookieStore()
|
|
|
| void MockSimplePersistentCookieStore::Load(
|
| const LoadedCallback& loaded_callback) {
|
| - std::vector<CanonicalCookie*> out_cookies;
|
| + std::vector<std::unique_ptr<CanonicalCookie>> out_cookies;
|
|
|
| - for (CanonicalCookieMap::const_iterator it = cookies_.begin();
|
| - it != cookies_.end(); it++)
|
| - out_cookies.push_back(new CanonicalCookie(it->second));
|
| + for (auto it = cookies_.begin(); it != cookies_.end(); it++)
|
| + out_cookies.push_back(base::MakeUnique<CanonicalCookie>(it->second));
|
|
|
| base::ThreadTaskRunnerHandle::Get()->PostTask(
|
| - FROM_HERE,
|
| - base::Bind(&LoadedCallbackTask::Run,
|
| - new LoadedCallbackTask(loaded_callback, out_cookies)));
|
| + FROM_HERE, base::Bind(loaded_callback, base::Passed(&out_cookies)));
|
| loaded_ = true;
|
| }
|
|
|
| @@ -183,11 +168,9 @@ void MockSimplePersistentCookieStore::LoadCookiesForKey(
|
| if (!loaded_) {
|
| Load(loaded_callback);
|
| } else {
|
| + std::vector<std::unique_ptr<CanonicalCookie>> empty_cookies;
|
| base::ThreadTaskRunnerHandle::Get()->PostTask(
|
| - FROM_HERE,
|
| - base::Bind(&LoadedCallbackTask::Run,
|
| - new LoadedCallbackTask(loaded_callback,
|
| - std::vector<CanonicalCookie*>())));
|
| + FROM_HERE, base::Bind(loaded_callback, base::Passed(&empty_cookies)));
|
| }
|
| }
|
|
|
|
|